middleware icon indicating copy to clipboard operation
middleware copied to clipboard

Published 20 hours ago • verified publisher icon honojs

feat: file upload middleware

Open krsbx opened this issue 2 years ago • 6 comments

Just a file upload middleware so the file can be saved to disk or passed to firebase firestorage or aws s3

krsbx avatar Sep 01 '23 01:09 krsbx

⚠️ No Changeset found

Latest commit: 7ef0fa16bf7c669e85fbc8d5e36ca2c97d907c2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 01 '23 01:09 changeset-bot[bot]

I cannot merge it. Sorry.

yusukebe avatar Sep 01 '23 02:09 yusukebe

@yusukebe sorry to bring this thing up again but is it cool if we just add this one the node-adapter instead? if yes, then i'll make a PR there

krsbx avatar Sep 26 '23 13:09 krsbx

Hi @krsbx

You do not need to create a PR immediately, but I would like to think more about file uploads. So, I will not merge it, but I will reopen this PR so that I do not forget it. Thanks.

yusukebe avatar Sep 26 '23 20:09 yusukebe

Where are we with this? This new integration is in the roadmap or should we wait?

Willing to take this forward if that's okay

sourabpramanik avatar Jun 08 '24 01:06 sourabpramanik

Hi @sourabpramanik

We don't plan to add a file upload feature. But you can use this one: https://github.com/sor4chi/hono-storage

yusukebe avatar Jun 08 '24 22:06 yusukebe