honojs
Codecov CI issues
Codecov running on CI needs improvement. This result shows it.
https://github.com/honojs/middleware/pull/1360/checks
1. codecov/project fails
2. All packages are covered
Ideally, only related packages should be covered.
Sure thing 👍🏻
I've been waiting for vitest v4 to be released which should help somewhat.. #1265
It's now in beta, so maybe we can merge that?
Ah, I see. It's a Vitest side issue! So, only v4 can fix it? Or we can still use v3 and fix it?
Yes, it's something to do with how Vitest generates coverage reports for each project. #1265 is passing using v4.0.0-beta.2, but failing with newer beta releases
honojs/middleware is regularly tested against main branch of Vitest. You can see what's failing https://github.com/vitest-dev/vitest-ecosystem-ci/actions/runs/16928252703/job/47968182844
It looks to be specifically related to @cloudflare/vitest-pool-workers
Ah, vitest-dev/vitest-ecosystem-ci! It's great that this repo is in it. So, is it a good idea to wait for the official release of v4?
Yes, I think it's a good idea to wait. Jumping in the beta will just create more maintenance headaches 🫨