honox icon indicating copy to clipboard operation
honox copied to clipboard

docs(README) test: bindings and variables from wrangler.toml

Open KaiSpencer opened this issue 1 year ago • 5 comments

Adds some documentation to the readme on how pull from wrangler.toml when using vite dev server

Also adds an e2e test ensuring the functionality works

Related: #76 #39

KaiSpencer avatar Feb 21 '24 12:02 KaiSpencer

Hi @KaiSpencer !

Thanks!

First, you should separate the PR between fixing the README and adding tests.

For testing. It might be better to do the testing on @hono/vite-dev-server and not on this project: https://github.com/honojs/vite-plugins/tree/main/packages/dev-server

Because @hono/vite-dev-server has the feature to handle Bindings. What do you think?

yusukebe avatar Feb 21 '24 13:02 yusukebe

Hi @KaiSpencer !

Thanks!

First, you should separate the PR between fixing the README and adding tests.

For testing. It might be better to do the testing on @hono/vite-dev-server and not on this project: https://github.com/honojs/vite-plugins/tree/main/packages/dev-server

Because @hono/vite-dev-server has the feature to handle Bindings. What do you think?

Hey @yusukebe,

Happy to separate the PR!

Yes I can understand how the tests would be better in the vite plugin, given honox devServer configuration option is exactly passed through and it is not manipulated/changed at all.

I will reduce this PR to be just docs changes, and make a separate PR over in that repo for a e2e test that covers this functionality

KaiSpencer avatar Feb 21 '24 13:02 KaiSpencer

Hi @KaiSpencer

Thanks! I've commented.

yusukebe avatar Feb 21 '24 13:02 yusukebe

Maybe this should be in "Deployment", but you might note that Cloudflare Pages does not read wrangler.toml in production, Remix does.

https://github.com/remix-run/remix/tree/main/templates/vite-cloudflare#deployment

Yeah, I considered if to put this into Deployment or to make Development, and changed my mind a few times along the way! I didnt notice that with remix, I gues it fits to both categories. Happy with with your direction on where you would like this

KaiSpencer avatar Feb 21 '24 13:02 KaiSpencer

Whilst writing this, I have come across this issue in the dev-server vite plugin. https://github.com/honojs/vite-plugins/issues/92

It does not change how this should be documented, we can carry on the testing discussion over there and just keep this to the docs change

KaiSpencer avatar Feb 21 '24 14:02 KaiSpencer