hono icon indicating copy to clipboard operation
hono copied to clipboard

a few minor edits

Open sharma-shray opened this issue 1 year ago • 2 comments

The author should do the following, if applicable

  • [ ] Add tests
  • [ ] Run tests
  • [ ] bun run format:fix && bun run lint:fix to format the code
  • [ ] Add TSDoc/JSDoc to document the code

sharma-shray avatar Oct 24 '24 17:10 sharma-shray

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.71%. Comparing base (0a99bd3) to head (ee32903). Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3557      +/-   ##
==========================================
+ Coverage   94.27%   94.71%   +0.44%     
==========================================
  Files         157      157              
  Lines        9501     9537      +36     
  Branches     2854     2783      -71     
==========================================
+ Hits         8957     9033      +76     
+ Misses        544      504      -40     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 24 '24 22:10 codecov[bot]

Hi @sharma-shray, thanks for the suggestion.

It may seem like a change that is obvious to you and doesn't need to be explained, but from the perspective of maintenance, it would be appreciated if the “why” was written in the commit message. Please use the following format as a reference for writing messages in future commits.

https://www.conventionalcommits.org/en/v1.0.0/

usualoma avatar Oct 24 '24 23:10 usualoma

Hi @sharma-shray

Thank you for the PR. Looks good. But next time, please follow the @usualoma 's comment.

yusukebe avatar Oct 31 '24 02:10 yusukebe