hono icon indicating copy to clipboard operation
hono copied to clipboard

[WIP] fix(serve-static): support Windows

Open yusukebe opened this issue 1 year ago • 1 comments

WIP

The author should do the following, if applicable

  • [ ] Add tests
  • [ ] Run tests
  • [ ] bun run format:fix && bun run lint:fix to format the code
  • [ ] Add TSDoc/JSDoc to document the code

yusukebe avatar Oct 01 '24 07:10 yusukebe

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.29%. Comparing base (09a81e4) to head (a9126d2). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3477      +/-   ##
==========================================
- Coverage   91.32%   91.29%   -0.03%     
==========================================
  Files         170      170              
  Lines       10812    10908      +96     
  Branches     3093     3168      +75     
==========================================
+ Hits         9874     9959      +85     
- Misses        937      948      +11     
  Partials        1        1              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 01 '24 07:10 codecov[bot]

Bundle size check

main (09a81e4) #3477 (9ac182a) +/-
Bundle Size (B) 18,206B 18,206B 0B
Bundle Size (KB) 17.78K 17.78K 0K

Compiler Diagnostics (tsc)

main (09a81e4) #3477 (9ac182a) +/-
Files 262 262 0
Lines 116,386 116,386 0
Identifiers 114,405 114,405 0
Symbols 259,899 259,899 0
Types 162,566 162,566 0
Instantiations 3,039,295 3,039,295 0
Memory used 273,450K 273,879K 429K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.91s 0.65s -0.26s
Bind time 0.29s 0.31s 0.02s
Check time 3.87s 4.04s 0.17s
Emit time 0s 0s 0s
Total time 5.07s 5.01s -0.06s

Compiler Diagnostics (typescript-go)

main (09a81e4) #3477 (9ac182a) +/-
Files 232 232 0
Lines 106,285 106,285 0
Identifiers 106,145 106,145 0
Symbols 371,531 371,531 0
Types 293,008 293,008 0
Instantiations 3,568,491 3,568,491 0
Memory used 229,700K 229,846K 146K
Memory allocs 10,003,575 10,003,534 -41
Parse time 0.067s 0.071s 0.004s
Bind time 0.016s 0.015s -0.001s
Check time 1.437s 1.393s -0.044s
Emit time 0s 0s 0s
Total time 1.522s 1.48s -0.042s

Reported by octocov

github-actions[bot] avatar Jul 03 '25 07:07 github-actions[bot]

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 35,739.91 49,118.36 30,679.41 27,421.97
hono (current) bun 36,939.88 50,661.56 32,144.47 28,013.61
Change +3.36% +3.14% +4.78% +2.16%

github-actions[bot] avatar Jul 03 '25 07:07 github-actions[bot]

Bundle size check

main (09a81e4) #3477 (917ed3b) +/-
Bundle Size (B) 18,206B 18,206B 0B
Bundle Size (KB) 17.78K 17.78K 0K

Compiler Diagnostics (tsc)

main (09a81e4) #3477 (917ed3b) +/-
Files 262 262 0
Lines 116,386 116,386 0
Identifiers 114,405 114,405 0
Symbols 259,899 259,899 0
Types 162,566 162,566 0
Instantiations 3,039,295 3,039,295 0
Memory used 273,450K 271,137K -2,313K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.91s 0.65s -0.26s
Bind time 0.29s 0.28s -0.01s
Check time 3.87s 3.7s -0.17s
Emit time 0s 0s 0s
Total time 5.07s 4.62s -0.45s

Compiler Diagnostics (typescript-go)

main (09a81e4) #3477 (917ed3b) +/-
Files 232 232 0
Lines 106,285 106,285 0
Identifiers 106,145 106,145 0
Symbols 371,531 371,531 0
Types 293,008 293,008 0
Instantiations 3,568,491 3,568,491 0
Memory used 229,700K 229,711K 11K
Memory allocs 10,003,575 10,003,500 -75
Parse time 0.067s 0.081s 0.014s
Bind time 0.016s 0.02s 0.004s
Check time 1.437s 1.575s 0.138s
Emit time 0s 0s 0s
Total time 1.522s 1.683s 0.161s

Reported by octocov

github-actions[bot] avatar Jul 03 '25 07:07 github-actions[bot]

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 38,497.59 52,335.58 33,987.71 29,169.48
hono (current) bun 38,019.25 51,476.40 33,539.97 29,041.38
Change -1.24% -1.64% -1.32% -0.44%

github-actions[bot] avatar Jul 03 '25 07:07 github-actions[bot]

Open in StackBlitz

npm i https://pkg.pr.new/hono@3477

commit: a9126d2

pkg-pr-new[bot] avatar Jul 03 '25 07:07 pkg-pr-new[bot]

Hi @oscarotero @dmytro-peleshenko

Sorry for being late! This RP may solve your problem. If you have time, can you try this branch to confirm it works well? You can install hono of this branch with the following command:

npm i https://pkg.pr.new/hono@3477

@usualoma (@ryuapp) I think this is okay. Can you review this?

yusukebe avatar Jul 03 '25 07:07 yusukebe

I think we can merge this. If you have any problems, please feel free to open an issue.

yusukebe avatar Jul 14 '25 05:07 yusukebe