shiva icon indicating copy to clipboard operation
shiva copied to clipboard

Published 20 hours ago • verified publisher icon honeynet

SSDEEP integration in Shiva

Open RahulBinjve-zz opened this issue 11 years ago • 4 comments

Please merge the changes made in SHIVA. I've added SSDEEP check for differentiating between spams. Also, new modules have been added, namely:

  1. ShivaAddNewRecord
  2. ShivaDecide
  3. ShivaProcessOld
  4. ShivaPushToDb

RahulBinjve-zz avatar Jul 17 '13 07:07 RahulBinjve-zz

Seems like you used to code a lot in Java :smile: I recommend you to have a look at: http://www.python.org/dev/peps/pep-0008/ It is common to use 4 spaces as indentation. Module names are all lower score and with underscores. class names are in CamelCase, methods are all lower case and with underscores. Sticking to some generally accepted standards significantly helps others to contribute code.

glaslos avatar Jul 17 '13 07:07 glaslos

Thanks a ton for the peer review, Lukas. Will surely work on the points you've mentioned. And will make the changes accordingly. :)

RahulBinjve-zz avatar Jul 17 '13 10:07 RahulBinjve-zz

Not sure about @b0nd 's opinion but I'd remove unused code.

glaslos avatar Jul 17 '13 11:07 glaslos

hi, i have read your gsoc blog

  1. this pull request is hard to review. could you please split it into more pull requests ? (like "SSDEEP integration", "Add hpfeeds", "X bug fix", "Changed MySQL storage engine from 'MyISAM' to 'InnoDB'") use one branch for one pull request
  2. other commentaries

katkad avatar Sep 10 '13 14:09 katkad