gha-buildevents icon indicating copy to clipboard operation
gha-buildevents copied to clipboard

Generate Spans for jobs in multi-job flows

Open fitz-vivodyne opened this issue 11 months ago • 0 comments

Is your feature request related to a problem? Please describe.

I'm testing out the project on a multi-job workflow. Following the documentation in the README appears to only create the init events.

This leaves you with a trace that only has a few sparse init events along a very empty timeline.

Describe the solution you'd like

Generate spans for each job within a multi-workflow build

Describe alternatives you've considered

Alternatively you could add manual instrumentation to each job in the workflow, but that adds more repetitive noise.

Additional context It looks like the postRun code is only called if the trace is supposed to end: https://github.com/honeycombio/gha-buildevents/blob/e891e91ad0fcd80b71430a97ebf5a9baecac388a/src/index.ts#L102-L106

I'm thinking there should always be a post run function to close a span, but conditionally close the trace.

fitz-vivodyne avatar Mar 26 '24 15:03 fitz-vivodyne