Reddit-Enhancement-Suite icon indicating copy to clipboard operation
Reddit-Enhancement-Suite copied to clipboard

Published 20 hours ago • verified publisher icon honestbleeps

Add WebDAV support to backups

Open ElijahPepe opened this issue 2 years ago • 6 comments

Relevant issue: #5273 Tested in browser: Firefox 90.0.1/99.0.1

ElijahPepe avatar May 01 '22 16:05 ElijahPepe

Thanks for the PR!

We are having some discussions on this among the team due to the concern of storing plaintext WebDAV credentials in file store in RES. Please stand by.

benmcgarry avatar May 02 '22 16:05 benmcgarry

Passwords for accounts are stored in plaintext.

ElijahPepe avatar May 02 '22 17:05 ElijahPepe

Reddit account passwords are a lot less risk compared to someones file storage.

benmcgarry avatar May 02 '22 17:05 benmcgarry

Very fair argument. Storing passwords in localStorage or the web SQL database API is obviously not feasible; any in-browser solutions are crackable.

The two ideas I have are to leave it as it is with a strong warning, or use OAuth and have the WebDAV connection work in the backend. There is a credential management API that could theoretically work, but it would require a lot more work than the other two solutions.

ElijahPepe avatar May 02 '22 18:05 ElijahPepe

Yeah I think having a strong warning might be the approach we want to go with. We have it in our privacy policy that we do store in plain text (https://redditenhancementsuite.com/privacy). But for this make it explicitly clear to say "Hey, these are the risks. Proceed with caution". Looking to see if we have a way we can flag a popup on user select to act as the warning.

benmcgarry avatar May 02 '22 18:05 benmcgarry

Looking to see if we have a way we can flag a popup on user select to act as the warning.

I added a commit to trigger a window.alert() using onChange(). Hopefully that works.

ElijahPepe avatar May 04 '22 21:05 ElijahPepe