Make permission 'history' optional

[larsjohnsen]

• The permission must be granted when opening an (by default non-selftext) expando or using the visited filter.
  • This may cause an annoying prompt
• The sfwHistory option is simplified to a simple on/off in order to remove complexity and reduce confusing coloration of visited links.

TODO:

• [ ] Figure out how to grant permissions in tests

Closes #4769

[larsjohnsen]

I realize now that this only changes the declared permission "Read and change your browsing history" to "Read your browsing history", which may not be worthwhile for the added trouble this makes.

[honestbleeps]

I think I agree on that one! Unfortunately there's just no good way to message this without the fearmongering tone of Chrome's dialog - which, while technically true, doesn't reflect what RES is actually doing. :-\

On Fri, Dec 14, 2018 at 9:28 AM larsjohnsen [email protected] wrote:

I realize now that this will only changes the declared permission "Read and change your browsing history" to "Read your browsing history", which may not be worthwhile for the added trouble this makes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/5003#issuecomment-447358723, or mute the thread https://github.com/notifications/unsubscribe-auth/AATws_a-KF9xKdlAQ41oqNPvDoXeoPZuks5u48ORgaJpZM4ZOeys .

[ghost]

I realize now that this only changes the declared permission "Read and change your browsing history" to "Read your browsing history", which may not be worthwhile for the added trouble this makes.

I think it's worthwhile