Reddit-Enhancement-Suite
Reddit-Enhancement-Suite copied to clipboard
honestbleeps
filteReddit support for reddit redesign
In between @larsjohnsen's very considerate upgrades to FilteReddit, particularly for "handling data not available" and me learning how to handle disjoint unions with exact types in Flow, this might actually be ready for testing.
I added an escape hatch option to disable filtering in redesign. I was considering adding a migration to turn that on if the user is on a beta channel.. maybe I could do that by parsing current version?
Has this been abandoned or is there a non-conflicted version somewhere?
@Mathnerd314 I pushed a rebase, though I have not done any further testing of this.
So the UI shows up and works, and it hides/shows things when you invert the filters. But all the filters match nothing, even the score filter. And it also doesn't seem to handle the redesign's infinite scroll at all, in that hiding hides only the first page of links and the rest are still visible.
I see in the console that the redesign is making requests to https://gateway.reddit.com/desktopapi and the responses have useful JSON data containing the posts. Is RES using that JSON or working backwards from the DOM?
watchForRedditEvents should trigger "examine and maybe filter this post/comment, both on initial pageload, SPA navigation to a new post listing, and infinite scroll. (RES doesn't examine the API responses initiated by the Reddit first-party code).
If RES isn't alerted to new posts, that fault could be due to Reddit failing to send events for them, or RES failing to catch and pass along the events for them. I see that if i visit https://new.reddit.com and look for user tags, they are not appearing. That problem could be isolated by testing with the JSAPI example extension
If the filters don't match something, that could be a fault somewhere in Thing.js -- either the Thing's property method doesn't have redesign support, or the property method is buggy.
Hi, I'm potentially looking to contribute to this pull request, if this is still the most relevant/active PR related to enabling the filters for the new design. Let me know—thanks.
