convention icon indicating copy to clipboard operation
convention copied to clipboard

TravisCI markdown checking

Open ThomDietrich opened this issue 5 years ago • 5 comments

How about adding a markdown style check to the CI chain?

I've defined a good remark-lint rule set here: https://github.com/openhab/openhab-docs/blob/gh-pages/package.json

ThomDietrich avatar Nov 29 '18 09:11 ThomDietrich

The CI chain on the website end is go and python. Do we really want to introduce a javascript chain as well? (Especially with all those horror messages about npm malware currently in the media)

davidgraeff avatar Nov 29 '18 18:11 davidgraeff

Don't know why not. It will only be executed within the isolated environment of TravisCI!? Besides, in terms of testing I believe that a consistent markdown style in the convention and all PRs should be of importance and is worth including in an automated way.

ThomDietrich avatar Nov 30 '18 09:11 ThomDietrich

Ok, I'm fine with it

davidgraeff avatar Nov 30 '18 09:11 davidgraeff

@ThomDietrich can this be closed?

mjcumming avatar May 05 '20 22:05 mjcumming

The MR is not yet there, is it?

davidgraeff avatar May 06 '20 09:05 davidgraeff