nba-go icon indicating copy to clipboard operation
nba-go copied to clipboard

Proposal: Team Information

Open CodyCahoon opened this issue 7 years ago • 6 comments

It would be cool to be able to see a team's record and past games. Maybe something like the following, using t and team

$ nba-go team cavaliers 
$ nba-go t CLE

This could also be extended for certain seasons such as wanting to see how the Cavaliers did in a specific season, or in 2015, using -y and --year

$ nba-go t CLE -y 2015
$ nba-go t CLE --year 2014

CodyCahoon avatar Nov 07 '17 02:11 CodyCahoon

This would be cool, and I believe the API nba-go used has team data for sure. Let me know if you would like to tackle this feature, PR is welcome! Or I'll do it ASAP.

homerchen19 avatar Nov 07 '17 02:11 homerchen19

I can tackle it, will post a PR!

CodyCahoon avatar Nov 07 '17 02:11 CodyCahoon

Thanks for your help!

homerchen19 avatar Nov 07 '17 03:11 homerchen19

@xxhomey19 I noticed that the data folder is populated with outdated JSON data and I'm curious if this is because you're never actually storing the data after scraping it and instead just printing it to command line. Any insight would be helpful.

nwisniowski avatar Apr 12 '18 19:04 nwisniowski

I would like to address this issue, I will publish a PR

CesarPZ avatar Jul 10 '19 00:07 CesarPZ

Me gustaría abordar este problema, publicaré un PR

I add the link to the PR: https://github.com/CesarPZ/nba-go/pull/2

lordmaster11 avatar Jul 10 '19 05:07 lordmaster11