github-file-icons icon indicating copy to clipboard operation
github-file-icons copied to clipboard

Published 20 hours ago • verified publisher icon homerchen19

Temporary .txt and .pdf fix

Open Morphclue opened this issue 1 year ago • 2 comments

Description

Unfortunately, I have not been able to locate the exact source of the error. However, I have temporarily fixed two icons which were addressed in Issues #126 and #128. To remember that this is a temporary solution this was documented in icons.css.

During development I've noticed that the .idea folder was not yet excluded for development with a JetBrains IDE. This folder is now excluded in the .gitignore.

Morphclue avatar Oct 14 '23 19:10 Morphclue

The reason PDF icons doesn't show up, is because it doesn't exists in atom-file-icons library (https://github.com/csandman/atom-file-icons/blob/main/src/css/icons.css). They have it registered in theirs icons "database" (https://github.com/csandman/atom-file-icons/blob/2cafbb420f62a36a7774337c806c578736c41b4c/src/db/icondb.js#L1521) but it just won't spawn any icon because of this.

XxOsirisxX77 avatar Feb 19 '24 21:02 XxOsirisxX77

Yes I hope we can fix the issue there

homerchen19 avatar Feb 20 '24 01:02 homerchen19