verified icon indicating copy to clipboard operation
verified copied to clipboard

homebridge-playstation-game-title

Open NikDevx opened this issue 1 year ago • 3 comments

Link To GitHub Repo

https://github.com/NikDevx/homebridge-playstation-game-title

Link To NPM Package

https://www.npmjs.com/package/homebridge-playstation-game-title

Plugin Icon (Optional)

No response

NikDevx avatar Feb 04 '24 21:02 NikDevx

:white_check_mark: Pre-checks completed successfully.

github-actions[bot] avatar Feb 04 '24 21:02 github-actions[bot]

Hi @NikDevx

Your plugin should not be displaying the verified badge until it has been verified on here.

Screenshot 2024-02-11 at 03 52 36

One of the points of verification is that the plugin doesn't replicate too much what another verified plugin already does. And in this case I noticed there is homebridge-playstation already verified.

If your plugin works differently, this is totally fine, it was just for some information about your plugin and how it might be different to the currently verified one!

Thanks

bwp91 avatar Feb 11 '24 03:02 bwp91

Hello @bwp91

If your plugin works differently, this is totally fine, it was just for some information about your plugin and how it might be different to the currently verified one!

My plugin uses a different library and different methods.

Your plugin should not be displaying the verified badge until it has been verified on here.

I was remove my verified badge.

I will wait to check. Thanks

NikDevx avatar Feb 11 '24 08:02 NikDevx

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 12 '24 11:03 github-actions[bot]

Any updates?

NikDevx avatar Mar 12 '24 21:03 NikDevx

  • General
    • [x] The plugin must be of type dynamic platform.
    • [x] The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • Repo
    • [x] The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
    • [x] A GitHub release should be created for every new version of your plugin, with release notes.
  • Environment
    • [x] The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
    • [x] The plugin must successfully install and not start unless it is configured.
    • [x] The plugin must not execute post-install scripts that modify the users' system in any way.
    • [x] The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • Codebase
    • [x] The plugin must implement the Homebridge Plugin Settings GUI.
    • [x] The plugin must not contain any analytics or calls that enable you to track the user.
    • [x] If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
    • [x] The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.



Comment /check to run checks again.

github-actions[bot] avatar Mar 16 '24 19:03 github-actions[bot]

Hi @NikDevx apologies for delay, a couple of things. I don't have a PlayStation so cannot test further than installing!

  1. Please enable issues on your repo so that users have a place to report issues with the plugin

    The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.

  2. What happens if the user does not have python installed on their homebridge instance? is this something you can check? just to make sure that it does not throw any errors which crash the homebridge process?

bwp91 avatar Mar 16 '24 19:03 bwp91

Hi @NikDevx apologies for delay, a couple of things. I don't have a PlayStation so cannot test further than installing!

  1. Please enable issues on your repo so that users have a place to report issues with the plugin

    The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.

  2. What happens if the user does not have python installed on their homebridge instance? is this something you can check? just to make sure that it does not throw any errors which crash the homebridge process?

Hello

  1. NPM published already. Issues did enable now.
  2. It will show error in logs need install python (I will check if it will not crash when python not installed)

NikDevx avatar Mar 16 '24 19:03 NikDevx

(I will check if it will not crash when python not installed)

thank you, will await your response 👍

bwp91 avatar Mar 16 '24 19:03 bwp91

(I will check if it will not crash when python not installed)

thank you, will await your response 👍

Hello @bwp91 I did update installation section in readme file. And when run without python3 install inside homebridge raise error about it and will not crash homebridge process.

NikDevx avatar Mar 22 '24 16:03 NikDevx

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community. https://homebridge.io

github-actions[bot] avatar Mar 25 '24 20:03 github-actions[bot]

Hello @bwp91 I did update installation section in readme file. And when run without python3 install inside homebridge raise error about it and will not crash homebridge process.

Thanks for confirming, all verified!

bwp91 avatar Mar 25 '24 20:03 bwp91