verified icon indicating copy to clipboard operation
verified copied to clipboard

homebridge-daikin-local-platform

Open tasict opened this issue 1 year ago • 7 comments

Link To GitHub Repo

https://github.com/tasict/homebridge-daikin-local-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-daikin-local-platform

Plugin Icon (Optional)

No response

tasict avatar Jan 09 '24 06:01 tasict

:white_check_mark: Pre-checks completed successfully.

github-actions[bot] avatar Jan 09 '24 06:01 github-actions[bot]

  • General
    • [x] The plugin must be of type dynamic platform.
    • [ ] The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • Repo
    • [x] The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
    • [x] A GitHub release should be created for every new version of your plugin, with release notes.
  • Environment
    • [x] The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
    • [x] The plugin must successfully install and not start unless it is configured.
    • [x] The plugin must not execute post-install scripts that modify the users' system in any way.
    • [x] The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • Codebase
    • [x] The plugin must implement the Homebridge Plugin Settings GUI.
    • [x] The plugin must not contain any analytics or calls that enable you to track the user.
    • [x] If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
    • [x] The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.



Comment /check to run checks again.

github-actions[bot] avatar Feb 11 '24 00:02 github-actions[bot]

/check

tasict avatar Feb 11 '24 00:02 tasict

:white_check_mark: Pre-checks completed successfully.

github-actions[bot] avatar Feb 11 '24 00:02 github-actions[bot]

Hi @tasict

I noticed in your README that you already have the homebridge verified badge, this really should not be there until your plugin has been verified.

Screenshot 2024-02-11 at 00 34 18

I had a couple of questions about verification:

  • we ideally would like just one verified plugin per plugin/functionality, and I noticed this plugin is already verified:
    • https://github.com/cbrandlehner/homebridge-daikin-local so I wondered how your plugin is different?
  • github releases are necessary for verification
  • in which file do you use the cheerio dependency in your package json file?

bwp91 avatar Feb 11 '24 00:02 bwp91

https://github.com/cbrandlehner/homebridge-daikin-local/issues/340

Due to certain factors, original plugin cannot support the new version of the air conditioner firmware. The author mentioned that, due to the architecture, it is not feasible to provide support by modifying the code in the short term. To ensure compatibility with HomeKit and continue using Homebridge for my air conditioner, I collaborated with the author to completely rewrite the plugin, enabling support for the new air conditioning firmware. If you have other aspects to mention, I will make the necessary modifications.

tasict avatar Feb 11 '24 10:02 tasict

@bwp91 Hi, I have modified the code and documentation. Please assist in reviewing the latest version. Thank you.

tasict avatar Feb 13 '24 05:02 tasict

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 14 '24 11:03 github-actions[bot]

@bwp91 Any update?

tasict avatar Mar 14 '24 13:03 tasict

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community. https://homebridge.io

github-actions[bot] avatar Mar 16 '24 18:03 github-actions[bot]

Apologies for delay - thanks for the info - all verified!

bwp91 avatar Mar 16 '24 18:03 bwp91