HAP-NodeJS
HAP-NodeJS copied to clipboard
Suggestion: Bump to 1.0
Hi! I'm maintaining two projects that depend on HAP-Nodejs, both have quite a bunch of users that are using them since years "in production". As HAP-Nodejs can be considered stable for a long time now I suggest to bump the Version to 1.0. Would have some advantages: You could fully utilize the semantic versioning scheme, patch only for bugfixes, minor for compatible changes/features, major for breaking changes. With the current 0.x scheme this is not possible, patch is bumped for features, changes and bugfixes and the role of the minor is unclear. For me as a maintainer of packages depending on HAP-Nodejs it would be much easier to specify a proper version range in the package.json - and last but not least: I see no reason for not doing it :-) @KhaosT what do you think? Regards, Sebastian
+1 for semantic versioning I have the same situation here
Here's a list of things I'd like to see before v1:
- [x] Remove
buffer-shim
- [x] Lose legacy compatibility (Node 10+ only)
- [ ] Transitioning
node-persist
to v3.0 - [x] Use Promises as well as callbacks
- [ ] Improve unit test coverage
- [ ] Create integration test suite using
hap-client
- [x] Add code quality tooling (ESLint + Prettier)
- [x] Set up CI/CD process
- [x] Add contributing documentation
Obviously all of them may not be realistic, but I'd love to hear other contributors' thoughts
Why break nodejs 8 before it is eol? Or wait till next April. ;-) What benefit would it have to only support node 10+?
@hassankhan Sounds legit :)
Create integration test suite using hap-client Set up CI/CD process
I can offer my help regarding integration tests and travis setup, I think we could reuse a lot of the testing setup of https://github.com/hobbyquaker/homekit2mqtt
Why break nodejs 8 before it is eol?
I would also suggest to support all versions as long as they are in maintenance, so for Node 8 until December 2019:
When I look at Hassans Todo for 1.0 - this will take a bit of time - So I guess 1.0 will be done when Node 8 is already EOL.
#778
This issue has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.
Can I add a bump and a vote for this? Semantic versioning would be helpful so we know about all breaking changes and can act accordingly!
As always, thanks for all your hard work!
v1.0.0 is planned to be the next release (apart from potential 0.9.x Bug fix releases).
v1.0.0 is planned to be the next release (apart from potential 0.9.x Bug fix releases).
So, it's been another year and we've gone through 0.9 and now 0.10... any new plans for 1.0 and true semver support?
Hello again. I'm back with a yearly reminder that the projects who depend on this library would really appreciate semantic versioning.
Is 2023 the year?!
Please?
How many more years do I need to come beg for this until we get semver and bump to 1.0?
Some day, but not today. It will come…a little housecleaning first.