dz icon indicating copy to clipboard operation
dz copied to clipboard

Swing Console: Celsius/Fahrenheit switch is broken

Open climategadgets opened this issue 7 years ago • 1 comments

How to reproduce: Press C or F key (command to switch between Celsius and Fahrenheit display) while the focus is on DZ Swing Console. Watch the grid change. After several sensor inputs, press it again.

Expected result:

  • Numbers on display change to reflect the new measurement unit;
  • The grid changes its view to reflect new measurement unit;
  • Temperature chart stays more or less the same.

Actual result:

  • Numbers on display change to reflect the new measurement unit;
  • Temperature chart shifts down (if changing from C to F) and stays there; however, new values are properly matched against the grid;
  • Grid autoscaling breaks because it now covers the range from C to F absolute values;
  • The display will stay this way until 3 hours plus autoscaling adjustment interval pass.

climategadgets avatar Oct 20 '18 07:10 climategadgets

Update: Celsius to Fahrenheit switch also puts the setpoint at apparently random Fahrenheit value. Along with the fact that up/down arrow changes the setpoint by 0.1°C, this results in being able to change the setpoint only by 0.2°F at a time, with either only odd or only even values, depending on how rounding worked when the Celsius to Fahrenheit switch was invoked.

Update: 359dd6cea11e52deaba55bd69492793a80b1ff3c took care of this; #138 will improve situation further.

climategadgets avatar Mar 11 '20 06:03 climategadgets

This bug is fixed in Reactive code base, however, #247 remains. Won't be fixed in Imperative code base, it's being retired.

climategadgets avatar Oct 27 '22 04:10 climategadgets