wheels-custom-integrations icon indicating copy to clipboard operation
wheels-custom-integrations copied to clipboard

Add questdb python client

Open diferhe opened this issue 1 year ago • 1 comments

Add questdb python client (repo) required by QSS custom integration. The upstream doesn't provide wheels for musl linux armv7.

diferhe avatar Sep 14 '24 12:09 diferhe

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Sep 14 '24 12:09 home-assistant[bot]

Ref: https://github.com/home-assistant/core/issues/132398 /CC @joostlek

cdce8p avatar Dec 08 '24 18:12 cdce8p

We like to avoid creating/hosting wheels in case project can provide them themselves.

Did you contact the upstream project to see if they want to add support for it? Alternative, you could maybe contribute the addition upstream?

The reason we like to push for this route, it that such changes benefit not just Home Assistant, but the entire Python ecosystem.

../Frenck

I did contact them 5 days ago (as I agree that it is better if it is provided by them), but no reply so far. Going through their issue tracker history, I don't have a lot of hope there :)

antst avatar Dec 10 '24 08:12 antst

BTW, if I see it right, this PR is not enough. There is also need to add extra apk ("cargo") to the list of apks in GitHub action. To build this wheel one need to have installed rust compiler, as it is written mostly in rust.

And important to note that this is not anymore issue of armv7, but issue on all platforms.

antst avatar Dec 11 '24 13:12 antst

BTW, if I see it right, this PR is not enough. There is also need to add extra apk ("cargo") to the list of apks in GitHub action. To build this wheel one need to have installed rust compiler, as it is written mostly in rust.

The wheel builder includes rust / cargo. So that should work out of the box. https://github.com/home-assistant/wheels?tab=readme-ov-file#platform-tags

cdce8p avatar Dec 11 '24 13:12 cdce8p

So, what do we do next? Upstream is not responding to request to provide binary.

antst avatar Dec 18 '24 01:12 antst

We like to avoid creating/hosting wheels in case project can provide them themselves.

Did you contact the upstream project to see if they want to add support for it? Alternative, you could maybe contribute the addition upstream?

The reason we like to push for this route, it that such changes benefit not just Home Assistant, but the entire Python ecosystem.

../Frenck

Frenck, as this is blocking change request, I can reconfirm(one more time, month later) that there is absolutely zero response from upstream on this matter. But it is annoying that every time after update of core, I have to build and install it manually. And,. I guess, this forces all users of qss extension (which needs this wheel) to drop it and go with less favorable ways.

antst avatar Dec 30 '24 14:12 antst

ping...

antst avatar Jan 07 '25 23:01 antst

@frenck Can you clarify, what is deal breaker now?

antst avatar Jan 19 '25 22:01 antst

If upstream still hasn't handled it, I guess it is fine to move forward on our end for the time being.

Thanks for you patience on this one @diferhe 👍

../Frenck

Thanks!

antst avatar Jan 23 '25 12:01 antst