supervisor icon indicating copy to clipboard operation
supervisor copied to clipboard

Add udisks2 dbus support

Open raman325 opened this issue 3 years ago • 1 comments

Proposed change

Closes https://github.com/home-assistant/supervisor/issues/2564

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (which adds functionality to the supervisor)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: https://github.com/home-assistant/supervisor/issues/2564
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast supervisor tests)
  • [ ] Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

raman325 avatar Sep 08 '22 04:09 raman325

Looking at the typed dictionaries in Block we could add something generic to the dbus utils that looks at a dictionary and converts it into one with Variant key values. It wouldn't be difficult to handle those since all the values are just str or int from the looks of it.

But I don't know what can go in options in these various method calls.

mdegat01 avatar Sep 19 '22 17:09 mdegat01

Looking at the typed dictionaries in Block we could add something generic to the dbus utils that looks at a dictionary and converts it into one with Variant key values. It wouldn't be difficult to handle those since all the values are just str or int from the looks of it.

But I don't know what can go in options in these various method calls.

this is a good idea, and options use basic types too (see my updates) but I think it makes more sense to do in a separate PR and think about it more holistically. There are few enough options here that it was simple to do it by hand

raman325 avatar Sep 28 '22 03:09 raman325

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 26 '22 20:11 github-actions[bot]

Not stale

raman325 avatar Nov 26 '22 20:11 raman325

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Dec 26 '22 22:12 github-actions[bot]