One light tests producing errors

[stevoh6]

HI, when I was trying to test enablid/disablid one light entity and write test for it, I ended up with following situation, could you please check it?

tests/sk/light_HassTurnOff.yaml

   - sentences:
       - "vypni nočnú lampu"
       - "zahas nočnú lampu"
       - "zhasni nočnú lampu"
     intent:
       name: "HassTurnOff"
       slots:
         name: "light.bedroom_lamp"
         domain: "light"

Produce error: FAILED tests/test_language_sentences.py::test_light_HassTurnOff[sk] - AssertionError: Slot domain was not expected for: vypni nočnú lampu

But if I remove 'domain' it throw another error. tests/sk/light_HassTurnOff.yaml

   - sentences:
       - "vypni nočnú lampu"
       - "zahas nočnú lampu"
       - "zhasni nočnú lampu"
     intent:
       name: "HassTurnOff"
       slots:
         name: "light.bedroom_lamp"
         # domain: "light"

Produce error: FAILED tests/test_language_sentences.py::test_light_HassTurnOff[sk] - AssertionError: File light_HassTurnOff: tests should have domain slot set to light

[mxwi]

The problem here should not be underestimated. I guess you are always affected by this problem when you have a room with more than one light (wild guess?)

Let's take my config as example:

light.kuchenspots (name: Küchenspots) in area "Küche" light.kuchenlamp (name: Küchenlampe) in area "Küche"

When I say "Dimme die Küchenspots auf 20%" (Dim the küchenspots to 20%) [I stay with my native language here to prevent missunderstandings] it dims every light that has "Spot" in it to 20% - all of them.

The problem is, that I don't have another option to toggle these lights individually.

Let's assume that the lights are now called:

light.kuchenspots (name: Spots) in area "Küche" light.kuchenlamp (name: Lamp) in area "Küche"

And I say: "Dimme die Spots in der Küche auf 20%" (Dim the spots in the kitchen to 20%); HomeAssistant does not understand this intend, because this case is not declared.

As already mentioned in #864

[dontinelli]

I encountered the same error. In my view it should be possible to define sentences to turn on/off one specific device/entity outside homeassistant_HassTurnOn/Off.

[schizza]

Solution is to add

requires_context: 
  domain: light

As in #946

ping @stevoh6 @dontinelli @mxwi

[stevoh6]

thx :) I will have time in end of the week look at it and other chenges :)

[dontinelli]

@schizza: I see that your PR #946 passed all tests. When I try to do the same (with adding a sentence in the test file), I still get an Error:

E                   AssertionError: Slot domain was not expected for: Schaut d Schlafzimmer Lampe y
E                   assert 'domain' in {'name': 'light.bedroom_lamp'}

tests/test_language_sentences.py:129: AssertionError
=========================================================================== short test summary info ============================================================================
FAILED tests/test_language_sentences.py::test_light_HassTurnOn[de-CH] - AssertionError: Slot domain was not expected for: Schaut d Schlafzimmer Lampe y
================================================================== 1 failed, 1 passed, 17 deselected in 0.25s ==================================================================

intents:
  HassTurnOn:
    data:
      - sentences:
          - "(Zünd|Mach|Schalt|Schaut) [<Liecht>] <name> [<a_y>]"
        slots:
          domain: light
        requires_context:
          domain: light
        response: light

tests:
  - sentences:
      - "Zünd d Schlafzimmer Lampe a"
      - "Schaut d Schlafzimmer Lampe y"
    intent:
      name: HassTurnOn
      slots:
        name: light.bedroom_lamp
        domain: light
    response:
      - "Ha ds Liecht schlafzimmer lampe igschalte."

The test passes, if I delete the sentences for turning on one light only (as you know from the last PR).

Furthermore, the test passes if the test sentence is "Zünd ds Liecht Schlafzimmer Lampe a". It therefore seems that the problem is in the similar sentence for the general HassTurnOn, even though lights should be excluded:

intents:
  HassTurnOn:
    data:
      - sentences:
          - "(Schalt|Schaut|Schteu|Stell|Mach) <name> <a_y>"
        excludes_context:
          domain: (light|fan)

What do I miss?

[schizza]

@schizza: I see that your PR #946 passed all tests. When I try to do the same (with adding a sentence in the test file), I still get an Error:

E                   AssertionError: Slot domain was not expected for: Schaut d Schlafzimmer Lampe y
E                   assert 'domain' in {'name': 'light.bedroom_lamp'}

tests/test_language_sentences.py:129: AssertionError
=========================================================================== short test summary info ============================================================================
FAILED tests/test_language_sentences.py::test_light_HassTurnOn[de-CH] - AssertionError: Slot domain was not expected for: Schaut d Schlafzimmer Lampe y
================================================================== 1 failed, 1 passed, 17 deselected in 0.25s ==================================================================

intents:
 HassTurnOn:
   data:
     - sentences:
         - "(Zünd|Mach|Schalt|Schaut) [<Liecht>] <name> [<a_y>]"
       slots:
         domain: light
       requires_context:
         domain: light
       response: light

tests:
 - sentences:
     - "Zünd d Schlafzimmer Lampe a"
     - "Schaut d Schlafzimmer Lampe y"
   intent:
     name: HassTurnOn
     slots:
       name: light.bedroom_lamp
       domain: light
   response:
     - "Ha ds Liecht schlafzimmer lampe igschalte."

The test passes, if I delete the sentences for turning on one light only (as you know from the last PR).

Furthermore, the test passes if the test sentence is "Zünd ds Liecht Schlafzimmer Lampe a". It therefore seems that the problem is in the similar sentence for the general HassTurnOn, even though lights should be excluded:

intents:
  HassTurnOn:
    data:
      - sentences:
          - "(Schalt|Schaut|Schteu|Stell|Mach) <name> <a_y>"
        excludes_context:
          domain: (light|fan)

What do I miss?

Actually, if I run tests on your branch only error is that you have a wrong answer:

      AssertionError: Incorrect response for: Zünd d Schlafzimmer Lampe a
E                   assert 'Ha ds Liächt schlafzimmer lampe igschalte.' in {'Ha ds Liecht schlafzimmer lampe igschalte.'}

[schizza]

@dontinelli

so the problem is that sentence "Schaut d Schlafzimmer Lampe y" is falling to homeassistant_HassTurnOn instead to light_HassTurnOn Sentence "Zünd d Schlafzimmer Lampe a" dont fall into homeassistant_HassTurnOn because you dont have such rule in homeassistant_HassTurnOn sentences for Zund, but for Schaut you have. In homeassistatnt_HassTurnOn is exclude_content but in wrong format (fan|light). Change it only to light and tests will pass as the sentence "Zünd d Schlafzimmer Lampe a" will be parsed in right place.

as you can see here:

{
  "text": "Zünd d Schlafzimmer Lampe a",
  "match": true,
  "intent": "HassTurnOn",
  "slots": {
    "name": "light.bedroom_lamp",
    "domain": "light"
  },
  "response_key": "light",
  "response": "Ha ds Liächt schlafzimmer lampe igschalte."
}

and on other hand:

{
  "text": "Schaut d Schlafzimmer Lampe y",
  "match": true,
  "intent": "HassTurnOn",
  "slots": {
    "name": "light.bedroom_lamp"
  },
  "response_key": "default",
  "response": "Has schlafzimmer lampe igschalte."
}

[dontinelli]

Thank you @schizza, it was indeed the wrong format in the exclude_context-syntax.

        excludes_context:
          domain: light, fan

With this I (currently) get all tests passed.

[mxwi]

so we have to adjust this in every language, correct?

[synesthesiam]

@dontinelli That should be:

        excludes_context:
          domain:
            - light
            - fan

[dontinelli]

@dontinelli That should be:

        excludes_context:
          domain:
            - light
            - fan

Thank you, in the meanwhile schizza told me the same and I amended accordingly.

[mxwi]

Am I missing something?

Ger: "Dimme die Spots in der Küche auf 20%"

Eng: "Dim the spots in the kitchen to 20%."

These statements are still not working for me.

Why?

[dontinelli]

Am I missing something?

Ger: "Dimme die Spots in der Küche auf 20%"

Eng: "Dim the spots in the kitchen to 20%."

These statements are still not working for me.

Why?

"die Spots" is not (yet) defined in German. "die Lichter" or "die Lampen" should work, though. I assume in English it's the same.