intents icon indicating copy to clipboard operation
intents copied to clipboard

[en] Add sentence variant for climate, including contraction for "is"

Open orrc opened this issue 2 years ago • 1 comments

Added a couple of sentences that I felt were missing as an English native speaker.

Plus added the option to have 's as a contraction for is, since it can be used in a lot of places in English. Even although I guess we end up with a space between the word and the contraction (e.g. how warm 's it) in the sentence, the tests seem happy with it.

orrc avatar Jan 09 '23 00:01 orrc

Hi orrc

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Jan 09 '23 00:01 home-assistant[bot]

@orrc do you want to update this PR or should I close it? I feel as though the value is minimal, but with proper tests we could merge it

tetele avatar Nov 09 '23 15:11 tetele

@tetele I don't have any preferences. I created this PR back in January, I believe when this project was announced, and there was a call for sentences to be added.

If there are new contributor guidelines, or documentation on what tests are necessary nowadays in this project, I can take a look.

But if the value of merging is minimal, then I'm also fine with closing it.

orrc avatar Nov 09 '23 15:11 orrc

Thanks for trying back then, sorry it took so long. I was doing some cleanup and bumped into it.

Again, considering where the voice functionality and the intents repo are at today, i'd say it's more of a hassle.

I'll close it, thank you for understanding!

tetele avatar Nov 09 '23 16:11 tetele