intents
intents copied to clipboard
[en] Add sentence variant for climate, including contraction for "is"
Added a couple of sentences that I felt were missing as an English native speaker.
Plus added the option to have 's as a contraction for is, since it can be used in a lot of places in English.
Even although I guess we end up with a space between the word and the contraction (e.g. how warm 's it) in the sentence, the tests seem happy with it.
Hi orrc
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
@orrc do you want to update this PR or should I close it? I feel as though the value is minimal, but with proper tests we could merge it
@tetele I don't have any preferences. I created this PR back in January, I believe when this project was announced, and there was a call for sentences to be added.
If there are new contributor guidelines, or documentation on what tests are necessary nowadays in this project, I can take a look.
But if the value of merging is minimal, then I'm also fine with closing it.
Thanks for trying back then, sorry it took so long. I was doing some cleanup and bumped into it.
Again, considering where the voice functionality and the intents repo are at today, i'd say it's more of a hassle.
I'll close it, thank you for understanding!