intents icon indicating copy to clipboard operation
intents copied to clipboard

[vi] more sentence possibilities for homeassistant_HassTurnOn.yaml

Open SaftigeSteaks opened this issue 9 months ago • 3 comments

Added some more vietnamese sentences possibilities

Summary by CodeRabbit

  • New Features
    • Enhanced Vietnamese language support by adding more flexible expressions for specifying location.
    • Improved smart home command patterns for turning on devices with more varied and expressive phrases.

SaftigeSteaks avatar Apr 29 '24 23:04 SaftigeSteaks

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Apr 29 '24 23:04 home-assistant[bot]

Walkthrough

Walkthrough

The recent updates enhance the flexibility and expressiveness of Vietnamese language processing in the context of smart home commands. Specifically, the modifications include expanding the expression for the word "in" and refining sentence patterns in the HassTurnOn intent to support more varied and natural commands for turning on devices.

Changes

File Change Summary
sentences/vi/_common.yaml Modified the expression for the word "in" to include "[ở] trong", enhancing location specification flexibility.
sentences/vi/homeassistant_HassTurnOn.yaml Updated sentence patterns to include additional phrases like "[]" and "lên" for more varied commands.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant Device

    User->>HomeAssistant: Turn on <device> [ở trong <area>]
    HomeAssistant->>Device: Send turn on command
    Device-->>HomeAssistant: Acknowledge turn on
    HomeAssistant-->>User: Confirm device is turned on

Recent review details

Configuration used: CodeRabbit UI Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 5a8beeca280198544a0c777d88fffee3e2d82c87 and 27410fd3fa78a187e34c308b2dda6380c2b74335.

Files selected for processing (2)
  • sentences/vi/_common.yaml (1 hunks)
  • sentences/vi/homeassistant_HassTurnOn.yaml (1 hunks)
Additional comments not posted (5)
sentences/vi/homeassistant_HassTurnOn.yaml (4)

6-6: Approved the addition of the new sentence pattern. It enhances flexibility in specifying commands.


7-7: Approved the addition of the new sentence pattern. It introduces a new expression style for turning on devices.


8-8: Approved the addition of the new sentence pattern. It adds variety to the verb choices for commands.


9-9: Approved the addition of the new sentence pattern. It significantly enhances command flexibility.

sentences/vi/_common.yaml (1)

352-352: Approved the update to the 'in' keyword. It enhances flexibility in specifying locations within sentences.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 30 '24 21:05 coderabbitai[bot]

@SaftigeSteaks Don't forget to add some tests for these cases 👍

frenck avatar Jun 08 '24 11:06 frenck

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

frenck avatar Oct 26 '24 13:10 frenck

@SaftigeSteaks @frenck sorry I missed the notification of this issue. I will take more time to update the Vietnamese intents.

dinhchinh82 avatar Oct 26 '24 16:10 dinhchinh82