intents icon indicating copy to clipboard operation
intents copied to clipboard

Published 20 hours ago • verified publisher icon home-assistant

Add more media player service calls

Open OzGav opened this issue 11 months ago • 1 comments

OzGav avatar Mar 08 '24 12:03 OzGav

As discussed on Discord, this PR is rather large. I'd advise you to break it up into smaller PRs, one for each new intent or pair of intents (such as Mute/Unmute). In order to prevent merge conflicts between the PRs, you can opt to use local lists.

tetele avatar Mar 08 '24 14:03 tetele

@tetele The split you've requested seem to have happened. Could you take another look?

@OzGav Meanwhile, a merge conflict has occurred as well. Could you take a look and resolve that?

Thanks! 👍

../Frenck

frenck avatar Jun 09 '24 11:06 frenck

IIRC, @synesthesiam said that these intents would not make the core, as they are too specific for MA. If so, let's close this PR for now.

But if I am mistaking, let me know and I can take another look. Either way, being new functionality (albeit in English), I'd like Mike to have the final say.

tetele avatar Jun 10 '24 07:06 tetele

Yes I understand we are just running with this one https://github.com/home-assistant/intents/pull/2080 That one has merge conflicts so maybe Frenck meant that one?

OzGav avatar Jun 10 '24 09:06 OzGav