intents icon indicating copy to clipboard operation
intents copied to clipboard

Update HassGetWeather.yaml (Partly Cloudy mismatch)

Open khalob opened this issue 1 year ago • 2 comments

When the weather is "Partly Cloudy" the HassGetWeather intent is not correctly matching the map value because it searches for "partly cloudy" instead of "partlycloudy". To keep things consistent, we can replace all spaces with hyphens, since that's how the map keys are formatted.

khalob avatar Feb 26 '24 02:02 khalob

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 26 '24 02:02 home-assistant[bot]

Thanks, but your PR is not enough to fix the issue. First off, you have the same issue which you left unaddressed for clear-night, lightning-rainy, snowy-rainy and windy-variant.

But more importantly, the issue runs deeper than this. See https://github.com/home-assistant/intents/discussions/1768 for clarification. We need a better solution which makes both translated and untranslated states available in the responses.

tetele avatar Feb 26 '24 07:02 tetele

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

frenck avatar Oct 26 '24 13:10 frenck