intents icon indicating copy to clipboard operation
intents copied to clipboard

[BG]Shopping list

Open rudizl opened this issue 1 year ago • 14 comments

First try to add BG shopping list to Assist

rudizl avatar Oct 11 '23 06:10 rudizl

Any help will be appreciated... :(

rudizl avatar Oct 11 '23 09:10 rudizl

I've left a PR on your repo. The indentation was wrong and YAML is very sensitive to indentation

tetele avatar Oct 11 '23 10:10 tetele

I've left a PR on your repo. The indentation was wrong and YAML is very sensitive to indentation

Thank you so much! Still can't pass all tests, but it's a step ahead :)

rudizl avatar Oct 11 '23 10:10 rudizl

It doesn't pass tests because of matching, not because of syntax errors, which is a step ahead :D

You're welcome and keep up the good work!

tetele avatar Oct 11 '23 10:10 tetele

I've left a PR on your repo. The indentation was wrong and YAML is very sensitive to indentation

Thank you so much! Still can't pass all tests, but it's a step ahead :)

I've left a PR on your repo. The indentation was wrong and YAML is very sensitive to indentation

Thank you so much! Still can't pass all tests, but it's a step ahead :)

Can you, please, connect to me in facebook, so I can give you some advices and we can have a talk between each other? Pleace, find me at: https://www.facebook.com/hristo.t.atanasov Connect to me and after we speak, we will resolve the issues you have. Thank You in advance!

hristo-atanasov avatar Oct 13 '23 04:10 hristo-atanasov

Hey @hristo-atanasov , @rudizl , I see that this PR is open for quite a long time. What needs to be done in order to pass the checks? Can I help with something in order to move it forward?

kyutov avatar May 20 '24 09:05 kyutov

Hey @hristo-atanasov , @rudizl , I see that this PR is open for quite a long time. What needs to be done in order to pass the checks? Can I help with something in order to move it forward?

If I only knew... :) Feel free to colaborate.

rudizl avatar May 20 '24 10:05 rudizl

Hey @hristo-atanasov , @rudizl , I see that this PR is open for quite a long time. What needs to be done in order to pass the checks? Can I help with something in order to move it forward?

If I only knew... :) Feel free to colaborate.

I have made some improvements to the tests and I have created a PR to your repo. I think that now the tests would cover all the available combinations of sentences. I hope that this will help to pass the checks.

kyutov avatar May 20 '24 13:05 kyutov

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 20 '24 15:05 home-assistant[bot]

@kyutov - pls check your CLA signature.

rudizl avatar May 20 '24 15:05 rudizl

@kyutov - pls check your CLA signature.

The error is caused by a wrong author details in the commit which I have made to your repo. I have amended the author details as the bot suggested and I have created a new PR to your repo.

kyutov avatar May 20 '24 18:05 kyutov

@rudizl , I see that the bot is still complaining about the author of my commit. I have delated the entire commit, so now the problem should be solved. I see that the problematic commit had disappeared from your repo as well. I think that now the bot will be happy so lets retry and we will see. If you prefer, you can rebase your repo before my commit and I will a new PR. Sorry for the mess 🤪

kyutov avatar May 21 '24 07:05 kyutov

@rudizl , I see that the bot is still complaining about the author of my commit. I have delated the entire commit, so now the problem should be solved. I see that the problematic commit had disappeared from your repo as well. I think that now the bot will be happy so lets retry and we will see. If you prefer, you can rebase your repo before my commit and I will a new PR. Sorry for the mess 🤪

I give up...

rudizl avatar May 21 '24 07:05 rudizl

I give up...

Yes, it is really annoying ... Feel free to delete my commits by resetting the branch to your last commit before mine and add my changes with your own commit.

kyutov avatar May 21 '24 08:05 kyutov