Add action widgets, open page widgets, and gauges on the Lock Screen
Summary
Allow action widget, open page widget, and watchOS style complications to be available on the iOS Lock Screen.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
Looking good! I will manually test and review the PR this week
Codecov Report
Attention: Patch coverage is 7.21649% with 90 lines in your changes missing coverage. Please review.
Project coverage is 27.53%. Comparing base (
6c34210) to head (7555425). Report is 145 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
- Coverage 27.54% 27.53% -0.02%
==========================================
Files 311 357 +46
Lines 31699 24572 -7127
==========================================
- Hits 8733 6767 -1966
+ Misses 22966 17805 -5161
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
btw bundle exec fastlane autocorrect to fix lint issues
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
You also need this code on line 81 in LegacyNotificationParserImpl, if you have time would be nice to make it all an enum
case "reload_widgets":
return .init("reload_widgets")
I haven’t managed to test the notification commands at all. I can’t seem to get my own firebase app connected to APNs properly.
Localization didn't work on my side, do you see it working fine when you edit the widget?
I haven’t managed to test the notification commands at all. I can’t seem to get my own firebase app connected to APNs properly.
I just manually tested it, and after the changes related to the enum above, all works well, we just need to add a note in the documentation telling the user that they can't keep reloading the widgets in a short period of time, since iOS will refuse to do it that often.
Btw, after these changes above we are good to merge, could you just update the docs? https://companion.home-assistant.io/docs/notifications/notification-commands
repo: https://github.com/home-assistant/companion.home-assistant
Localization was working fine for me until I changed my locale. The localized string resources don’t seem to have a fallback for when the string isn’t in the current locale unless you explicitly set it, so I just added defaults for English.
Anything else you want to add? Otherwise I can merge it (Asking because you didnt hit the "ready to review" button)
Oh, no I just forgot to hit the button
Oh, no I just forgot to hit the button
Thank you for your contribution! Don't forget a small update in https://companion.home-assistant.io/docs/notifications/notification-commands
repo: https://github.com/home-assistant/companion.home-assistant
Sorry for commenting but just wondering if any documentation for these new widgets will be added?