home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

Add backward-incompatible change to 2024.8

Open jschollenberger opened this issue 1 year ago • 3 comments

Proposed change

Provide a warning that a recent change modified the behavior of picture, picture elements, picture entity, and picture glance cards with no way to revert the behavior.

Type of change

  • [ ] Spelling, grammar or other readability improvements (current branch).
  • [x] Adjusted missing or incorrect information in the current documentation (current branch).
  • [ ] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [ ] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • [ ] Removed stale or deprecated documentation.

Additional information

https://github.com/home-assistant/frontend/pull/20593 https://github.com/home-assistant/frontend/issues/21738

Checklist

  • [x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x] The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Updated image handling for "Picture" cards associated with person entities to inherit images directly from the person, streamlining the process.
  • Documentation

    • Enhanced documentation to provide context for the changes and reference related development efforts.

jschollenberger avatar Aug 28 '24 18:08 jschollenberger

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

home-assistant[bot] avatar Aug 28 '24 18:08 home-assistant[bot]

Walkthrough

Walkthrough

The changes modify the handling of the image attribute in the "Picture, Picture Elements, Picture Entity, and Picture Glance cards" when associated with a person entity. The new functionality stipulates that the image attribute will no longer be customizable for person entities, as the image will now be inherited directly from the person entity itself.

Changes

Files Change Summary
source/_posts/2024-08-07-release-20248.markdown Updated functionality for image handling in specific cards to inherit images from person entities, removing customization options.

Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2011d32179ae0e9cc55119bc5955577151a5803a and 383dd69057635d84fdd720854fcb99af323bd93b.

Files selected for processing (1)
  • source/_posts/2024-08-07-release-20248.markdown (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • source/_posts/2024-08-07-release-20248.markdown

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 28 '24 18:08 coderabbitai[bot]

Deploy Preview for home-assistant-docs ready!

Name Link
Latest commit 383dd69057635d84fdd720854fcb99af323bd93b
Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66cf7795853877000802e694
Deploy Preview https://deploy-preview-34481--home-assistant-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 28 '24 18:08 netlify[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Sep 25 '24 07:09 home-assistant[bot]

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

frenck avatar Nov 10 '24 21:11 frenck