home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

docs(duwi): Add a new integration document for duwi

Open duwi2024 opened this issue 1 year ago • 3 comments

Proposed change

Following the insightful feedback provided by the Home Assistant Team on my initial submission, I have made several enhancements to the Duwi Integration PR for reevaluation. These changes aim to align with Home Assistant's standards and development procedures more closely. Notably, I've adhered strictly to the PR template, ensuring every required detail is meticulously reported for unequivocal understanding and assessment.

Type of change

  • [ ] Spelling, grammar or other readability improvements (current branch).
  • [ ] Adjusted missing or incorrect information in the current documentation (current branch).
  • [x] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [x] I've opened up a PR to add logos and icons in the Brands repository.
  • [ ] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • [ ] Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • [x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x] The documentation follows the Home Assistant documentation standards.

duwi2024 avatar May 24 '24 01:05 duwi2024

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

home-assistant[bot] avatar May 24 '24 01:05 home-assistant[bot]

Deploy Preview for home-assistant-docs ready!

Name Link
Latest commit b036b6626c3e3182a48e811fe27f3c3581dff232
Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66601f023df415000834ce9b
Deploy Preview https://deploy-preview-32919--home-assistant-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 24 '24 01:05 netlify[bot]

Please remove the duwi icon from the 'green' folder. It does not belong there.

c0ffeeca7 avatar May 24 '24 08:05 c0ffeeca7

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

home-assistant[bot] avatar May 27 '24 09:05 home-assistant[bot]

@c0ffeeca7 I've made the requested changes. Could you please take another look when you have a moment? Thank you!

Ledgerbiggg avatar May 30 '24 01:05 Ledgerbiggg

@duwi2024 Why did you close this PR? There is still a parent PR linked & open.

frenck avatar Jun 05 '24 08:06 frenck

Sorry for closing the PR earlier. I will continue to submit my PR.😢

Ledgerbiggg avatar Jun 05 '24 08:06 Ledgerbiggg

@c0ffeeca7 I've made the requested changes. Could you please take another look when you have a moment? Thank you!

I often wait with starting the docs review until the code review has been completed. It is more efficient. During code review, often changes require changes to the docs.

c0ffeeca7 avatar Jun 05 '24 08:06 c0ffeeca7

Okay, I understand. I am deeply sorry for my behavior and any inconvenience caused to you. I will continue to submit the PR for the document warehouse. I am truly sorry

Ledgerbiggg avatar Jun 05 '24 08:06 Ledgerbiggg