home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

Add integration docs for APsystems API

Open mawoka-myblock opened this issue 1 year ago • 1 comments

Proposed change

Adds integration docs

Type of change

  • [ ] Spelling, grammar or other readability improvements (current branch).
  • [ ] Adjusted missing or incorrect information in the current documentation (current branch).
  • [x] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [ ] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • [ ] Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: https://github.com/home-assistant/core/pull/114531
  • Link to parent pull request in the Brands repository: https://github.com/home-assistant/brands/pull/5433
  • This PR fixes or closes issue: fixes #

Checklist

  • [x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x] The documentation follows the Home Assistant documentation standards.

mawoka-myblock avatar Mar 30 '24 13:03 mawoka-myblock

Deploy Preview for home-assistant-docs ready!

Name Link
Latest commit 56e8bd4c29a6e054f822a5ab500654b68df36902
Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/664b1cafd22d550008548a78
Deploy Preview https://deploy-preview-32096--home-assistant-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 30 '24 13:03 netlify[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 16 '24 09:05 home-assistant[bot]

Thanks. I've commented the code out, as this will be added soon when I finish the other PRs in the core.

mawoka-myblock avatar May 20 '24 07:05 mawoka-myblock

Thanks. I've commented the code out, as this will be added soon when I finish the other PRs in the core.

ah, I was just going to ask about the comments. Please remove them from this PR, if they are related to changes from other core PRs.

c0ffeeca7 avatar May 20 '24 07:05 c0ffeeca7

Okay, removed the comments

mawoka-myblock avatar May 20 '24 08:05 mawoka-myblock

Why did you close the PR?

mawoka-myblock avatar May 20 '24 09:05 mawoka-myblock

Why did you close the PR?

I didn't. You did in https://github.com/home-assistant/core/pull/117782

CleanShot 2024-05-20 at 11 15 29@2x

You marked this PR to be closed by GitHub when that one would be merged by assign the fixes keyword in front of the PR.

../Frenck

frenck avatar May 20 '24 09:05 frenck

Oh! I didn't know that and also didn't expect that, as I've just linked to a comment in this PR, not to the PR itself.

mawoka-myblock avatar May 20 '24 09:05 mawoka-myblock

No problem, thank you for your nice feedback and all the commit suggestions below immediately! Really appreciate that!

mawoka-myblock avatar May 20 '24 09:05 mawoka-myblock