home-assistant.io icon indicating copy to clipboard operation
home-assistant.io copied to clipboard

Remove contradiction in sunset condition

Open janick opened this issue 1 year ago • 4 comments

Remove contradiction in current documentation of sunset condition.

Current documentation documents a work-around (using an explicit 'or' to specify "before sunrise or after sunset").

Note "before sunrise / after sunset" example still does not work. Fixed in https://github.com/home-assistant/core/pull/76143

Proposed change

Type of change

  • [ ] Spelling, grammar or other readability improvements (current branch).
  • [ ] Adjusted missing or incorrect information in the current documentation (current branch).
  • [ ] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [x] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • [ ] Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: https://github.com/home-assistant/core/pull/76143
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • [x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x] The documentation follows the Home Assistant documentation standards.

janick avatar Sep 05 '22 03:09 janick

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed. (message by DocsTargetBranch)

Could you rebase your branch to the next branch so that the unrelated commits disappear from your pull request.

klaasnicolaas avatar Sep 06 '22 19:09 klaasnicolaas

I thought I already did when I merged the 'next' branch in.

Guess I have to figure out how to rebase from here...

janick avatar Sep 06 '22 20:09 janick

This ought to do it...

janick avatar Sep 06 '22 21:09 janick