frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Settings > System > General: Naming of "find_currency_value" confusing and URL non-localizable

Open NoRi2909 opened this issue 1 year ago • 0 comments

Describe the issue you are experiencing

In Settings > System > General that also comes up during onboarding, there is a link "Find my value" below the Currency field that is supposed to be helpful but is rather confusing instead:

image

For a currency a "value" is the current exchange rate to other currencies.

Describe the behavior you expected

This links to the list of ISO 4217 currency codes on Wikipedia: https://en.wikipedia.org/wiki/ISO_4217#Active_codes

So the correct name for the link would be

 "Find my ISO code"

In addition the link should be made translatable by exposing it to Lokalise as this page is available in several languages. Here the German version: https://de.wikipedia.org/wiki/ISO_4217#Aktuell_g%C3%BCltige_W%C3%A4hrungen

Found here

https://github.com/home-assistant/frontend/blob/a04a449eb9059c097d5872fc44cb41659ed0a59a/src/translations/en.json#L2381

What version of Home Assistant Core has the issue?

core-2024.10.2

NoRi2909 avatar Oct 18 '24 08:10 NoRi2909