frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Style fixes

Open yosilevy opened this issue 1 year ago • 1 comments

Breaking change

Proposed change

Style cleanup - inline

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (thank you!)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [X] Code quality improvements to existing code or addition of tests

Example configuration


Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • [X] The code change is tested and works locally.
  • [X] There is no commented out code in this PR.
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

yosilevy avatar Apr 17 '24 03:04 yosilevy

Some older browsers still don't support the CSS logical properties (like margin-inline-start and margin-inline-end) and fallback to the margin-left and margin-right properties. Removing those will probably take away the margin completely if support is missing, but I'm not entirely sure.

silamon avatar Apr 17 '24 16:04 silamon

@silamon @bramkragten some devs on the team started entering only the logical properties so I followed suite. We can decide not to do it yet although I don't think users need this. This is common spread by now.

yosilevy avatar May 06 '24 13:05 yosilevy

For the legacy build I want to add a css converter that handles this, let's wait for that

bramkragten avatar May 06 '24 13:05 bramkragten

@bramkragten Should we delete this PR?

yosilevy avatar May 19 '24 10:05 yosilevy

I'm closing the PR as we don't have css converter for that for now. We will remove the unused property when it will have it.

piitaya avatar Jun 07 '24 14:06 piitaya