Renaming entity IDs when renaming a device can fail

[balloob]

Checklist

• [X] I have updated to the latest available Home Assistant version.
• [X] I have cleared the cache of my browser.
• [X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

When we rename a device, we prompt the user if they want to change the entity ID. If the user clicks yes but the device name is not unique, it can happen that it tries to assign an entity ID to an entity that already exists. In that case, it gives a confusing error:

Describe the behavior you expected

I would expect that it would append a _2 etc to the entity ID until a rename succeeds.

Steps to reproduce the issue

1. Get 2 the same devices
2. Rename first to "Cotton Eye Joe" and click "Yes" when prompted to rename entities
3. Rename second to "Cotton Eye Joe" and click "Yes" when prompted to rename entities

What version of Home Assistant Core has the issue?

core-2023.11.4

What was the last working version of Home Assistant Core?

Don't know

In which browser are you experiencing the issue with?

Arc

Which operating system are you using to run this browser?

MacOS

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.