frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Light "favorite color" picker remove function is broken

Open Traxtar928 opened this issue 1 year ago • 9 comments

Checklist

  • [X] I have updated to the latest available Home Assistant version.
  • [X] I have cleared the cache of my browser.
  • [X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

Light entity interface (shows brightness slider, picker for brightness/color wheel/color temp, and 8x default favorite colors). When editing favorite colors, each color bubble has a ( - ) minus icon for removing it, but selecting it does not remove the color.

Describe the behavior you expected

Selecting the ( - ) icon in the corner of any favorite color should remove it.

Option to "set default favorite colors" and "restore default favorite colors" is missing. Default favorite colors should be global, and additional options to set defaults per room or per light is recommended.

Steps to reproduce the issue

  1. Open light entity
  2. Select 3 dot menu
  3. Select "edit favorite colors"
  4. Select ( - ) icon to remove color

What version of Home Assistant Core has the issue?

2023.11.2

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Chrome, Firefox, Android app

Which operating system are you using to run this browser?

Android 13

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

Traxtar928 avatar Nov 22 '23 00:11 Traxtar928

It works fine for me. You don't get the dialog popup when you click the minus?

image

karwosts avatar Nov 22 '23 00:11 karwosts

I do not. Do you know if there's a service or setting that needs to be enabled for these messages to show up? Maybe it's a configuration issue. I even cleared the app data and started with a "fresh" mobile interface, and the message does not display.

Using a browser interface on Chrome and Firefox using Mobile or desktop mode did not show the message either.

Traxtar928 avatar Nov 22 '23 00:11 Traxtar928

Tested on iOS and can't seem to replicate, I will test on Android shortly to see if it's occurring on there. @Traxtar928 are you using the default light cards or custom?

ghost avatar Nov 23 '23 23:11 ghost

@

https://github.com/home-assistant/frontend/assets/46948982/9a1b8196-2aa5-4ffe-9e85-939faa1bcfb6

See video for reference.

Traxtar928 avatar Nov 24 '23 13:11 Traxtar928

I do remember seeing someone report something similar once (can't find it at the moment), but they didn't claim that it never worked, just that it was very difficult, like they had to tap it 30 times before the minus sign registered.

karwosts avatar Nov 24 '23 21:11 karwosts

I have not yet had it work properly, and finally reported it after trying to resolve it on my own over the past 2 weeks.

I realize my video doesn't show my presses to be very accurate, but I can assure anyone reading this that I have made countless unsuccessful attempts to get a pop-up asking for confirmation to delete the color.

Perhaps instead of the minus icon, dragging the color to a trashcan icon for removal would work better?

Traxtar928 avatar Nov 24 '23 21:11 Traxtar928

The video really helps. :+1: The buttons (both edit and minus) don't respond anymore to their actions from as soon as you're dragging. You can see in the video that is the case, although dragging a very short period of time.

silamon avatar Nov 25 '23 09:11 silamon

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 23 '24 10:02 github-actions[bot]

I've had this issue since I started using Home Assistant mid last year, and thought I was just stupid. Apparently it doesn't work in the Android app—I cannot get it to no matter what.

cassidyjames avatar Feb 26 '24 02:02 cassidyjames

Same for me, doesnt work in both android app and browser.

vian3072 avatar Mar 02 '24 23:03 vian3072

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 01 '24 01:06 github-actions[bot]

This is still reproducible for me on a Pixel 8, Android 14, Home Assistant 2024.5.5, frontend 202400501.1.

cassidyjames avatar Jun 07 '24 21:06 cassidyjames

This is still reproducible on a Pixel 8 with Android 14, Home Assistant 2024.6.2, frontend 20240610.0.

cassidyjames avatar Jun 13 '24 16:06 cassidyjames