frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Multiple tip windows when dragging history graphs

Open tomjhou opened this issue 2 years ago • 7 comments

Checklist

  • [X] I have updated to the latest available Home Assistant version.
  • [X] I have cleared the cache of my browser.
  • [X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

This issue affects the mobile version.

If I drag to scroll the UI, and happen to start the scroll from a history graph, a tip window pops up (giving detailed info), even though 99% of the time that is not my intention, as I am usually scrolling to see something else (i.e. not the graph).

Not only that, these tip windows behave abnormally. Drag-triggered tip windows add to existing tip windows, rather than replacing them. After a few drag-scrolls, many tip windows will be open at once (screenshot below shows 3 tip windows). These are especially hard to get rid of, as (unlike normal tip windows) they can only be dismissed by clicking in the SAME graph, and each one has to be dismissed one by one. And if you aren't careful, attempting to dismiss these windows just causes another window to pop up (if you happen to click a trace in the window, which is hard to avoid).

Describe the behavior you expected

Tool tip windows should not trigger if click is accompanied by drag. And if they do pop up, they should be dismissible in the normal way, by clicking anywhere on the UI, not just in the exact same history window.

Steps to reproduce the issue

  1. Click any point in any history graph while also dragging. This elicits a tool tip window that is hard to get rid of.
  2. Dragging the UI from additional history graphs will produce tip windows for all of them, with no apparent limit. ...

What version of Home Assistant Core has the issue?

Latest version (updated yesterday).

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Any mobile version

Which operating system are you using to run this browser?

Android

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

tomjhou avatar Sep 25 '23 13:09 tomjhou

Experiencing a similar situation (although, perhaps different since I noticed this when viewing a graph from the History section) and it has made checking specific data points on a graph viewed in the History section when on the iOS companion app a no-go.

When clicking on a data point in the graph, it opens the entity card instead of showing me the value for the selected data point. Video recording below:

https://github.com/home-assistant/frontend/assets/52541649/bab04bdc-3e1d-4709-9411-996de63fff45

As you can see, as soon as I stop scrolling through the data on the graph (raise my finger off of the screen), a new window of the entity pops up. Same behavior occurs if clicking on a single point on the graph.

RobertD502 avatar Oct 04 '23 20:10 RobertD502

Same issue on 2023.10.1.

blandry3 avatar Oct 08 '23 17:10 blandry3

This has been annoying me since 2023.10 Only now have I been bothered enough to investigate if anyone else noticed it.

I was going to raise a new issue until I found this issue so I will add my 2cents.

Issue started with 2023.10 Issue occurs in both iOS app and chrome for iOS.

Here is what happens when I use my finger to scroll a page with multiple graphs on it

image

Then when I actually want to look at a particular graph, the tips shown on the previous page are carried over to the new page and are still visible making it very cluttered and confusing as they are not relevant to the isolated graph being shown.

image

del13r avatar Nov 15 '23 20:11 del13r

Similar issue here where I'm unable to reliably dismiss the popup once it's activated. Usually requires clicking on the same graph again in order to get the popup to go away.

https://github.com/home-assistant/frontend/assets/1903507/b54606b3-1d8e-4843-a46c-f77b0dd0b49f

ColColonCleaner avatar Nov 17 '23 20:11 ColColonCleaner

Hi, is there any interest in fixing this issue? Issue started with 2023.10 We are now in 2024.1 and the issue is still present.

del13r avatar Jan 19 '24 06:01 del13r

It was there before 2023.10 if I'm remembering correctly. There was a patch for a similar issue around that time, but not this issue. Either way it would be great to see this fixed!

ColColonCleaner avatar Jan 19 '24 13:01 ColColonCleaner

Hello, original poster here. I'm glad to see I'm not the only one bothered by this. I'm also surprised this issue is still not fixed. Also, it seems there is a whole other thread on this issue: https://github.com/home-assistant/frontend/issues/18198

tomjhou avatar Feb 23 '24 15:02 tomjhou

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 30 '24 10:07 github-actions[bot]

bump

RobertD502 avatar Jul 30 '24 20:07 RobertD502