home-assistant
Handle "idle" state of alert entity
Breaking change
Proposed change
Add "idle " state to gallery and ensure correct color (was automatically red before).
Backend translation strings are added via https://github.com/home-assistant/core/pull/83926.
Type of change
- [ ] Dependency upgrade
- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (thank you!)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Example configuration
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue or discussion:
- Link to documentation pull request:
Checklist
- [X] The code change is tested and works locally.
- [X] There is no commented out code in this PR.
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
I think there is a difference though.
On = Alert is active. Off = Alert is active but acknowledged Idle = Alert is inactive.
This means that an Off state, is still the alerting situation. But it is no longer sending out notifications for it.
For that reason, I think having off & idle the same colors might not be correct.
I think there is a difference though.
On = Alert is active. Off = Alert is active but acknowledged Idle = Alert is inactive.
This means that an Off state, is still the alerting situation. But it is no longer sending out notifications for it.
For that reason, I think having off & idle the same colors might not be correct.
That would then mean "off" = "green"?
Agree with Bram, orange maybe.
Off means the alert is still there, it is just being silenced for notifications (acknowledged).
Makes me think, If we should change the translations (which you opened up a PR for @ Core).
off -> "Acknowledged"
on -> "Active", or maybe even "Alert"
idle -> "Idle", or maybe "Inactive"
