Make badge colors use the generic error/warning/success/info colors

[spacegaier]

Breaking change

Proposed change

The default badge colors were slightly different from the generic error, warning, success and info colors we use throughout the UI. Feels inconsistent to me.

@matthiasdebaat Do you know if there is a particular reason? Anything speaking against aligning/merging them?

And since we will always have values set for those --label-badge-[color] vars, I don't think we need separate defaults in state badge component as that is just one more place where we have to keep color codes in sync?

Type of change

• [ ] Dependency upgrade
• [X] Bugfix (non-breaking change which fixes an issue)
• [ ] New feature (thank you!)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• [X] The code change is tested and works locally.
• [X] There is no commented out code in this PR.
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

[matthiasdebaat]

The default badge colors were slightly different from the generic error, warning, success and info colors we use throughout the UI. Feels inconsistent to me.

@matthiasdebaat Do you know if there is a particular reason? Anything speaking against aligning/merging them?

And since we will always have values set for those --label-badge-[color] vars, I don't think we need separate defaults in state badge component as that is just one more place where we have to keep color codes in sync?

Not that I'm aware of. Sounds like a good change!

[bramkragten]

This change will need a dev blog post for theme creators, as this could be breaking.

If you have now customised the error color and didn't customize label-badge-red, label-badge-red will now be a different color.

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.