Move Editing of Dashboard to config page

[zsarnett]

Breaking change

Proposed change

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New feature (thank you!)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• [ ] The code change is tested and works locally.
• [ ] There is no commented out code in this PR.
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

[frenck]

I feel like this is a bit inconsistent.

We use the pencil icon

in Automations, Scenes, Scripts & Zones; and could not find any other occurrence using an edit button with "edit" as a text in a data table.

Is there a specific reason this one is different?

[spacegaier]

I agree with Frank. We should be consistent and use the pencil icon here.

[matthiasdebaat]

How about this on desktop (prototype). On desktop we show the buttons on hover. I've also changed the button to View, because with the different options added to the table you can open different kind of things.

And this on mobile (prototype). On smaller devices in an overflow menu.

[spacegaier]

Why only show on hover? For the other tables (automations, scripts, ...) we always show the icons. Overflow for narrow screens is a good idea.

[zsarnett]

Why should we only do what we have already done? I agree with consistency though. We just need to make sure to update the others to be consistent

Showing on hover is a good way to clean up a dashboard on load. Less Busy. Just need to make sure it's accessible

[frenck]

Why should we only do what we have already done?

If you want my vote, please don't go the route of big textual buttons in data tables, I might be acceptable in the English language, but especially with translations that can become too large to be friendly (and grow unexpectedly in size). I would prefer the icon in those cases instead.

However, that is a different discussion, not sure if that should be solved in this PR. I like the suggestion made by @matthiasdebaat, feels natural to do; but maybe we should overhaul that in a separate PR for all data tables.

[zsarnett]

I do agree with using the icons for edit instead. I didn't look at anything before adding this. Going to change to icon before merging then do the Matthias design in a different PR

[frenck]

I do agree with using the icons for edit instead.

Aah ok, my misunderstanding / bad. 👍

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[spacegaier]

@zsarnett Do you plan on moving that forward with the pencil icon for the edit mode?

[frenck]

We'll close this PR for now. This should originate from out of UX.

../Frenck