frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Added minimum and maximum chart properties to hui-history-graph-card

Open reubenbijl opened this issue 2 years ago • 4 comments

Breaking change

Proposed change

Addition of Minimum and Maximum Values to the history Graph. One issue I see with making a change like this is where do you stop with the customisation of the graph? Do you start allowing specific colours per entity? Do you make it possible to pass any chart.js configuration through from yaml instead of minimum and maximum like this? Interested in some more thoughts on this before implementing tests/updating documentation.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (thank you!)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Example configuration


Additional information

  • This PR fixes or closes issue: fixes #12622
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • [ x ] The code change is tested and works locally.
  • [ x] There is no commented out code in this PR.
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

reubenbijl avatar May 08 '22 02:05 reubenbijl

I seem to remember we already have something similar for other graphs (was it perhaps the footer graph in a sensor card?). Perhaps something to look at and align with (if I am not completely off here 🤔).

spacegaier avatar May 08 '22 09:05 spacegaier

I seem to remember we already have something similar for other graphs (was it perhaps the footer graph in a sensor card?). Perhaps something to look at and align with (if I am not completely off here 🤔).

The closest one that I can think of is the gauge card, which has the minimum/maximum properties as well. Screen Shot 2022-05-08 at 9 33 52 PM

reubenbijl avatar May 08 '22 09:05 reubenbijl

Had a quick look: I am referring to this: https://www.home-assistant.io/dashboards/sensor/#limits

spacegaier avatar May 08 '22 09:05 spacegaier

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 06 '22 10:08 github-actions[bot]