frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Update entity dialog doesn't change when the update is finished

Open raman325 opened this issue 3 years ago • 3 comments
trafficstars

Checklist

  • [X] I have updated to the latest available Home Assistant version.
  • [X] I have cleared the cache of my browser.
  • [X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

Testing this on HA OS (core v2022.5.0b7), when using the update entity to install an update via the update modal, the modal implies that the update is still in progress well after the update is actually done. Per Paulus, this is somewhat expected because we use the More Info dialog, but to me the behavior does not make sense.

Observations:

  • Underneath the modal, the update notification eventually disappears so it seems that the installation is complete
  • The modal stays open
  • The modal implies that the update is still in progress (the behavior of the modal doesn't change after clicking Install and before/after the update is complete)

Describe the behavior you expected

Either the modal should be closed or it should change to indicate that the installation is done

Steps to reproduce the issue

  1. Have an update available in Settings panel
  2. Open update
  3. Click install
  4. Wait

What version of Home Assistant Core has the issue?

2022.5.0b7

What was the last working version of Home Assistant Core?

2022.4.x

In which browser are you experiencing the issue with?

Google Chrome 100.0.4896.88

Which operating system are you using to run this browser?

macOS Monterey (12.3.1)

State of relevant entities

I did not check this

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

raman325 avatar May 04 '22 18:05 raman325

We know the in_progress state attribute goes from true or <int> -> false. Thus we could just show an installation complete message 🤷 Heck, we could even trigger a party popper shooting confetti 🎉

frenck avatar May 05 '22 07:05 frenck

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 03 '22 08:08 github-actions[bot]

Missed the bot. IMHO still relevant.

frenck avatar Aug 11 '22 07:08 frenck

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 09 '22 08:11 github-actions[bot]

is this still relevant? Now it's at least more obvious that the installation is done because there is no more progress and the buttons are still greyed out, but I think it could still be improved with more explicit messaging

raman325 avatar Nov 09 '22 16:11 raman325

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 31 '23 18:10 github-actions[bot]