developers.home-assistant icon indicating copy to clipboard operation
developers.home-assistant copied to clipboard

Update no score to include config flow

Open gjohansson-ST opened this issue 1 year ago • 1 comments

Proposed change

As with ADR-0010 we need a config flow so it should be a requirement for no score (if applicable)

Type of change

  • [x] Document existing features within Home Assistant
  • [ ] Document new or changing features which there is an existing pull request elsewhere
  • [ ] Spelling or grammatical corrections, or rewording for improved clarity
  • [ ] Changes to the backend of this documentation
  • [ ] Removed stale or deprecated documentation

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to relevant existing code or pull request:

gjohansson-ST avatar Mar 30 '24 12:03 gjohansson-ST

Hmm, I like the idea to review the quality scale. I do think we will move all non config flow integrations that could use a conversion into a limbo, because apparently they don't align with the bare minimum.

I would like to see some new rules in there that improve code quality like for example:

  • Uses strict typing
  • Efficiently make use of shorthand attributes (i.e., don't store state in self._state if you are directly going to return it in native_value property.
  • Migrate to has_entity_name
  • Make use of translatable entity names
  • Make use of icon translations
  • Be sure to have a predictable state from the code (not the right wording, but my point being, use enum sensors where possible, use proper device classes where possible as these increase the userfriendliness by a lot regarding voice control and automations)

joostlek avatar Mar 30 '24 12:03 joostlek

Let's revisit this as a whole, and close this one up for now.

../Frenck

frenck avatar Jun 08 '24 09:06 frenck