core icon indicating copy to clipboard operation
core copied to clipboard

Add support for lights via remote GPIO

Open antonverburg opened this issue 1 year ago • 7 comments

Proposed change

Add support for single-color, RGB and RGBW lights controlled via PIGPIO on raspberries.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/28731

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [X] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [X] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

antonverburg avatar Aug 30 '23 10:08 antonverburg

Currently there is an issue with using PWMLED in HA OS (https://github.com/soldag/python-pwmled/issues/9). Please wait with merge until issue in PWMLED has been resolved and version number of PWMLED is increased to 1.6.11.

antonverburg avatar Sep 08 '23 11:09 antonverburg

Version number of PWMLED is increased to 1.6.11. Has been tested on my own system. This pull request is ready to be merged after a review.

antonverburg avatar Oct 16 '23 08:10 antonverburg

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Dec 15 '23 09:12 github-actions[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Dec 15 '23 11:12 home-assistant[bot]

Hi Emontnemery, according to adrr 10: Integrations that communicate with devices and/or services are only configured via the UI.

Does this mean that I should rewrite the whole set of remote-io integrations to support config flows instead of yaml in this case?

antonverburg avatar Dec 16 '23 15:12 antonverburg

@antonverburg ADR 10 states: GPIO is given as an example of integrations which should be configured via YAML:

Integrations that integrate transports. These integrations allow users to define their own protocol. Examples include MQTT, serial, GPIO.

Hence, remote_rpi_gpio falls under the type of integration where YAML is allowed.

emontnemery avatar Dec 18 '23 20:12 emontnemery

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Feb 16 '24 21:02 github-actions[bot]