core icon indicating copy to clipboard operation
core copied to clipboard

Add a manual_watering service

Open Marc1200 opened this issue 2 years ago • 14 comments

The problem

I can't find a way to start a sprinkler manual with a custom amount of time. i saw the hydrawise integration supports 5,10,15,30,45,60 minutes. i want to create an helper to start a sprinkler switch with one of the above times out of an input_select box. is this possible? i tried with an automation, but it doesn't support watering_minutes as argument when i use the service switch_turn_on

What version of Home Assistant Core has the issue?

core-2023.6.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Hydrawise

Link to integration documentation on our website

https://www.home-assistant.io/integrations/hydrawise/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

Marc1200 avatar Jun 15 '23 11:06 Marc1200

Hey there @dknowles2, @ptcryan, mind taking a look at this issue as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hydrawise can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign hydrawise Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


hydrawise documentation hydrawise source (message by IssueLinks)

home-assistant[bot] avatar Jun 15 '23 11:06 home-assistant[bot]

It's not configurable at runtime; you have to hard-code it in your configuration.yaml file.

I'll keep this in mind as I'm moving the integration over to the newer Hydrawise API.

dknowles2 avatar Jun 15 '23 23:06 dknowles2

It's not configurable at runtime; you have to hard-code it in your configuration.yaml file.

I'll keep this in mind as I'm moving the integration over to the newer Hydrawise API.

Thanks for all the work on this, it's a great integration! I know you are working on updating to the new API, I look forward to using it. As of recent with the existing integration even though I have the watering minutes hardcoded, it doesn't seem to honor this limit anymore. It appears to just run after it's started.

`switch:

  • platform: hydrawise watering_minutes: 10`
image image

akeslo avatar Aug 08 '23 01:08 akeslo

I think what we actually want here is to have manual watering be a service instead of a switch. Services are much more natural for this, as they take arguments.

dknowles2 avatar Oct 06 '23 12:10 dknowles2

@home-assistant rename Add a manual_watering service

dknowles2 avatar Oct 06 '23 12:10 dknowles2

Hi,

Any update on the manual watering service that allows a time slider to be selected before turning on (or a selection from a configured list?)

I have multiple zones but each require a different amount of runtime to apply the desired water amounts. Any way to hardcode watering minutes per zone?

The current integration does not give me any options to select run time when turning on Manual Watering. Manual watering does not follow the zone runtime configured in the hydrawise app either.

rgricos avatar Nov 07 '23 02:11 rgricos

No progress yet. There are a few other cleanups I have pending first.

dknowles2 avatar Nov 08 '23 02:11 dknowles2

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

This is pending https://github.com/home-assistant/core/pull/106904

dknowles2 avatar Feb 08 '24 13:02 dknowles2

Hi. I agree with the issue of not manually setting the watering time, but I also have another problem. Namely, after using a single manual switch, after a while all entities become unavailable. The same if I want to turn on several at once in automation, it doesn't work. There is an error in the logs. I have HASSIO core 2024.4 Screenshot_2024-04-10-16-57-56-92_c3a231c25ed346e59462e84656a70e50

kosmaluk avatar Apr 10 '24 16:04 kosmaluk

@dknowles2 Any update on #94649? Would love to be able to set the manual watering times per zone or at least adjust the fixed time.

Thanks for all your work on this integration!

rlinick avatar Jun 27 '24 16:06 rlinick

Same here. To be honest, that is for me a must have. Otherwise there is no need to have it in home assistant. I need to activate in parallel my pump. Is it possible to make another variable for the time? No matter how to set it. Also yaml is okay for me. But unfortunately the integration is useless for me without setting a different time for each zones.

Stroett avatar Jun 29 '24 18:06 Stroett

The temp solution to this is so simple. The current code is updated to set “manual water” for an infinite time (or a long duration like 4 hours) and you use HA automation schedules/buttons to control your water times (with time run slides). Very easy to do.

I have previously requested this to be updated or a workable way to override the default run time but no response.

On Sun, 30 Jun 2024 at 4:25 AM, Stroett @.***> wrote:

Same here. To be honest, that is for me a must have. Otherwise there is no need to have it in home assistant. I need to activate in parallel my pump. Is it possible to make another variable for the time? No matter how to set it. Also yaml is okay for me. But unfortunately the integration is useless for me without setting a different time for each zones.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/94649#issuecomment-2198286324, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDYMQ5WDX3I2WEEXAQJQLNLZJ33YDAVCNFSM6AAAAAAZHVT6I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGI4DMMZSGQ . You are receiving this because you commented.Message ID: @.***>

rgricos avatar Jun 30 '24 02:06 rgricos

Totally agree. Then I would be able to control the duration by myself by using timers in the automation. Don't know what to do. For know I need to activate it twice or more to get my runtime. But that is not the intention I hope.

Stroett avatar Jun 30 '24 05:06 Stroett

@dknowles2 I would gladly buy you 10 cups of coffee today for this added functionality tomorrow (near future).

I know it's not a trivial amount of work required for these kinds of updates. Please let me pay you for your time.

Thanks!

rlinick avatar Jun 30 '24 14:06 rlinick

I had been waiting to land https://github.com/home-assistant/core/pull/116302 before adding services, because I thought that targeting valve entities would make the most intuitive sense. Looking at it again, it seems fine to just target the zone binary_sensors instead, so I sent https://github.com/home-assistant/core/pull/120883 to do that.

We missed the window for the 2024.7 release, but hopefully we can get this merged for 2024.8.

dknowles2 avatar Jun 30 '24 20:06 dknowles2