core icon indicating copy to clipboard operation
core copied to clipboard

Don't add Roborock switches if it is not supported

Open Lash-L opened this issue 2 years ago • 1 comments
trafficstars

Breaking change

Proposed change

Roborock devices return 'unknown_method' if the command is not supported. in the most recent bump, that is now an exception that is thrown(and caught by the send method in device.py and raises HomeAssistantError)

So if a HomeAssistantError is raised, we should avoid adding this entity.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #94044
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Lash-L avatar Jun 05 '23 13:06 Lash-L

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Jun 05 '23 13:06 home-assistant[bot]

Will that patch coverage be an issue? Can't think of a good way of just patching send command to test for one argument that gets called in this specific test without creating a new fixture. Which I could do - but it seems ineffective.

Lash-L avatar Jun 05 '23 19:06 Lash-L

This was on top of the version bump done in #94035 - I don't think anything will inherently be broken - but I assumed the version bump would be included in the beta release as well. The Exception being raised for an unknown method was added in the version bump, without it, I don't think this actually will fix anything

That is my bad, I should have realized the milestone wasn't on the version bump

Lash-L avatar Jun 05 '23 21:06 Lash-L

Correct. I've update HA but the issue persists.

luca-angemi avatar Jun 06 '23 04:06 luca-angemi