core icon indicating copy to clipboard operation
core copied to clipboard

Update component electrasmart (Add preset capability)

Open rubeecube opened this issue 1 year ago • 2 comments

Fixing back ElectraSmart component, adding capability to enable the Shabat mode present in code already

Breaking change

Proposed change

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

rubeecube avatar Jun 05 '23 13:06 rubeecube

Hi @bokobok

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Jun 05 '23 13:06 home-assistant[bot]

Hey there @jafar-atili, mind taking a look at this pull request as it has been labeled with an integration (electrasmart) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of electrasmart can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign electrasmart Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Jun 05 '23 13:06 home-assistant[bot]

@bokobok, did you verify the functionality with the current code? (I know you did back then with the custom integration)

jafar-atili avatar Jun 06 '23 07:06 jafar-atili

@jafar-atili I honestly do not know how to check the entire core I did check the component alone (I have a fork that I currently use since Shabat that is working well : https://github.com/bokobok/home-assistant-electrasmart )

The function needed for the preset ability is present: climate.py:308 (async_set_preset_mode)

rubeecube avatar Jun 06 '23 08:06 rubeecube

Hi @rubeecube

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Jun 28 '23 07:06 home-assistant[bot]

Hi @rubeecube

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Jun 28 '23 07:06 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jun 28 '23 07:06 home-assistant[bot]

@frenck done!

rubeecube avatar Jun 28 '23 07:06 rubeecube

Thanks for the quick turnaround @rubeecube 👍

../Frenck

frenck avatar Jun 28 '23 07:06 frenck