core icon indicating copy to clipboard operation
core copied to clipboard

Vodafone Station device tracker

Open chemelli74 opened this issue 2 years ago • 2 comments

Breaking change

Proposed change

Introducing Vodafone Station support. First platform: device_tracker

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

chemelli74 avatar Jun 04 '23 13:06 chemelli74

@paoloantinori ;-)

chemelli74 avatar Jun 04 '23 13:06 chemelli74

Sounds good, thanks for the integration!

Which models are supported? Are you going to add a documentation to this PR as well?

freeDom- avatar Jun 05 '23 09:06 freeDom-

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jul 26 '23 14:07 home-assistant[bot]

Reviewed library for compliance. Adr004 is ok because scraping is only used for login

bdraco avatar Aug 27 '23 17:08 bdraco