core icon indicating copy to clipboard operation
core copied to clipboard

Change Ezviz detection sensitivity to update per entity

Open RenierM26 opened this issue 2 years ago • 3 comments

Proposed change

The entity is now responsible for querying detection sensitivity of the camera.

  • This allows the user to disable querying per device entity.
  • Results in a drastic speed increase due to simultaneous requests.
  • Reduced API timeouts. (Especially if user has multiple cameras)

Had to bump dependency for this:

Compare: https://github.com/BaQs/pyEzviz/compare/0.2.0.15...0.2.0.17 Releases: https://github.com/BaQs/pyEzviz/releases

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [X] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #85238
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

RenierM26 avatar Jun 03 '23 09:06 RenierM26

Hey there @baqs, mind taking a look at this pull request as it has been labeled with an integration (ezviz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ezviz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ezviz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Jun 03 '23 09:06 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jun 05 '23 05:06 home-assistant[bot]

Should we tag this for the June release?

MartinHjelmare avatar Jun 05 '23 16:06 MartinHjelmare

Removing this from milestone because it relies on a dependency bump of https://github.com/home-assistant/core/pull/93710 and it's unclear if that can just be included.

balloob avatar Jun 08 '23 17:06 balloob