core icon indicating copy to clipboard operation
core copied to clipboard

Homekit Bridge adding accessories not selected as "included"

Open kidrocker151 opened this issue 1 year ago • 28 comments

The problem

When configuring HomeKit Bridge and you set "inclusion mode" to "include" and select your devices you want to include in HomeKit, every device shows up in your home including ones you did not check to include.

What version of Home Assistant Core has the issue?

core-2023.5.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

HomeKit Bridge

Link to integration documentation on our website

https://www.home-assistant.io/integrations/homekit

Diagnostics information

config_entry-homekit-24e79bfdd072cb9a706e010f0a03f0fd.json.txt

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

kidrocker151 avatar May 24 '23 03:05 kidrocker151

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


homekit documentation homekit source (message by IssueLinks)

home-assistant[bot] avatar May 24 '23 03:05 home-assistant[bot]

I'm having the same issue.

fpaddict avatar Jun 15 '23 03:06 fpaddict

Chiming in with the same problem, even on 2023.6.2. All my devices are showing in Homekit despite not being selected. There are also duplicate entries for the same device.

For what it's worth, am still on the old Home architecture.

borez avatar Jun 18 '23 02:06 borez

I’m also seeing this issue. What can I provide or test to help?

TommyJW avatar Jun 29 '23 11:06 TommyJW

I experienced this same issue when recently setting up a second HomeKit Bridge via the UI. Currently have both of my UI Bridges in Exclude mode to get around this issue, but would be great to have the option for Include working properly.

jmluxem avatar Jul 03 '23 00:07 jmluxem

Please list the entities that are showing up unexpectedly.

bdraco avatar Jul 03 '23 00:07 bdraco

      "options": {
        "filter": {
          "include_domains": [
            "humidifier",
            "lock",
            "media_player",
            "remote",
            "water_heater",
            "camera",
            "fan",
            "climate",
            "cover",
            "vacuum",
            "switch",
            "light",
            "alarm_control_panel"
          ],
          "exclude_domains": [],
          "include_entities": [],
          "exclude_entities": [
            "switch.bar_garland_socket_1",
            "camera.front_door",
            "climate.refrigerator_freezer",
            "climate.refrigerator_fridge",
            "media_player.bedroom_tv",
            "media_player.bedroom_xbox",
            "media_player.chad_s_2nd_fire_tv",
            "media_player.chad_s_echo_dot",
            "media_player.chad_s_fire_tv",
            "media_player.chad_s_kitchen_echo_show",
            "media_player.chad_s_living_room_echo",
            "media_player.chad_s_master_bedroom",
            "media_player.chad_s_tap",
            "media_player.chads_x",
            "media_player.everywhere",
            "media_player.dad_s_echo",
            "media_player.g3_instant_speaker",
            "media_player.garage_echo_flex",
            "media_player.home",
            "media_player.garage_speaker",
            "media_player.living_room",
            "media_player.living_room_firetv",
            "media_player.living_room_tv",
            "media_player.living_room_speaker",
            "media_player.mom_s_echo_dot",
            "media_player.my_office_echo",
            "media_player.office_4",
            "media_player.office_series_s",
            "media_player.office_tv",
            "media_player.parent_s_basement_echo",
            "media_player.parent_s_garage_echo_dot",
            "media_player.parent_s_kitchen_echo_show",
            "media_player.parent_s_living_room_echo",
            "media_player.parent_s_thermostat",
            "media_player.parent_s_office_echo_dot",
            "media_player.plex_plex_for_android_tv_aftjmst12",
            "media_player.plex_plex_for_android_tv_aftka",
            "media_player.plex_plex_for_android_tv_aftmm",
            "media_player.plex_plex_for_android_tv_fire_tv",
            "media_player.plex_plex_for_apple_tv_office_4",
            "media_player.plex_plex_for_ios_chad_s_ipad",
            "media_player.plex_plex_for_ios_chad_s_iphone",
            "media_player.plex_plex_for_lg_lg_75un7070puc",
            "media_player.plex_plex_for_roku_50_element_roku_tv",
            "media_player.plex_plex_for_roku_55_tcl_roku_tv",
            "media_player.plex_plex_for_roku_bedroom_tv",
            "media_player.plex_plex_for_xbox_chads_x",
            "media_player.plex_plex_web_firefox_windows",
            "media_player.plex_plex_web_firefox_windows_2",
            "media_player.sonos_left_2",
            "media_player.plex_plex_web_firefox",
            "media_player.plex_plex_web_chrome",
            "media_player.this_device_2",
            "media_player.unnamed_room",
            "media_player.thermostat",
            "remote.bedroom_tv",
            "remote.bedroom_xbox_remote",
            "remote.chads_x_remote",
            "remote.office_4",
            "remote.office_series_s_remote",
            "switch.adguard_filtering",
            "switch.adguard_protection",
            "switch.adguard_safe_browsing",
            "switch.adguard_parental_control",
            "switch.adguard_safe_search",
            "switch.fan_switch_1",
            "switch.light_switch_1",
            "switch.fluxer",
            "switch.basement_garland_socket_1",
            "switch.basement_tree_socket_1",
            "switch.office_fan_switch_1",
            "switch.office_light_switch_1",
            "switch.christmas_lights_socket_1",
            "switch.refrigerator_express_mode"
          ]
        },
        "mode": "bridge",

Based on your posted configuration, you should expect everything in include_domains to show up except for the specifically excluded ones

bdraco avatar Jul 03 '23 00:07 bdraco

For some odd reason, I managed to resolve the issue by clearing all my selections, applying the changes, and re-applying the selections. Realised the selections weren't applied when I downloaded my configuration file.

Also if you select a domain without including any devices, all devices in that domain will be automatically included.

#Select entities from each domain in “Climate, Light, Media Player, Scripts, Sensor, Switch”. The include will cover the entire domain if you do not select any entities for a given domain.

borez avatar Jul 03 '23 01:07 borez

For some odd reason, I managed to resolve the issue by clearing all my selections, applying the changes, and re-applying the selections. Realised the selections weren't applied when I downloaded my configuration file.

Also if you select a domain without including any devices, all devices in that domain will be automatically included.

#Select entities from each domain in “Climate, Light, Media Player, Scripts, Sensor, Switch”. The include will cover the entire domain if you do not select any entities for a given domain.

Thank you - I’ve been trying to move over to using homekit as the primary means for my other half to access our smart home and this issue was ruining the experience. I was able to be more mindful when I setup again and it looks as it should.

JHClagg avatar Jul 09 '23 20:07 JHClagg

I face this issue sometimes. An example I found to reproduce the issue is everytime is add a Garage Door Battery Sensor. It will add the Garage Door as well (if you have Covers selected under Inclusions) despite I have not selected the actual Garage Door entity itself.

codyc1515 avatar Jul 20 '23 03:07 codyc1515

Same issue here. I have selected a few "switch" entities to be visible, but some that I did not include are still visible in homekit nevertheless ...

1aranzant avatar Sep 24 '23 13:09 1aranzant

I got this issue as well. Looks like it has been 6 months since this issue first talked about, still no fix ? @bdraco

L1cardo avatar Dec 02 '23 17:12 L1cardo

Never could replicate the issue and there aren't working reproduction steps here

bdraco avatar Dec 02 '23 18:12 bdraco

In my case I made a bridge and selected both scene and script domains. I then selected a few scene entities but no scripts. The selected scenes plus all scripts appeared. Was able to observe it pretty consistently. Since then I just remove the domain until I need it but that’s just a workaround.

mmerickel avatar Dec 02 '23 18:12 mmerickel

I can easily get some repro steps. Let me check on this.

codyc1515 avatar Dec 02 '23 18:12 codyc1515

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Still an issue. I need to get more examples.

codyc1515 avatar Dec 17 '23 01:12 codyc1515

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Still happens.

codyc1515 avatar Dec 31 '23 01:12 codyc1515

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

I had the same problem. When I select all the domian, either in bridge mode or accessory mode, it syncs the entities that I don't select'include' to HomeKit

Haaooo avatar Jan 17 '24 11:01 Haaooo

Can confirm for domain Binary sensor. Selecting domain without selecting entity within domain leads to all domain entities being published to HomeKit. Reversible through reconfigure and remove domain. Multiple attempts made, consistently reproducible.

Home Assistant Core 2024.1.3 Home Assistant OS 11.4

jsundgot avatar Jan 17 '24 17:01 jsundgot

I don’t think that is the same issue.

Example to reproduce is a Device with two Entities from different Domains say Fan and Climate.

Problem: You select Include option and Fan and Climate from domains then select the Fan entity only. Both the Fan and Climate become exposed to HomeKit.

No Problem: You select Include option and Fan (but not Climate) from domains then select the Fan entity. Only the Fan becomes exposed to HomeKit.

codyc1515 avatar Jan 17 '24 18:01 codyc1515

I don’t think that is the same issue.

Example to reproduce is a Device with two Entities from different Domains say Fan and Climate.

Problem: You select Include option and Fan and Climate from domains then select the Fan entity only. Both the Fan and Climate become exposed to HomeKit.

No Problem: You select Include option and Fan (but not Climate) from domains then select the Fan entity. Only the Fan becomes exposed to HomeKit.

Can confirm for domain Binary sensor. Selecting domain without selecting entity within domain leads to all domain entities being published to HomeKit. Reversible through reconfigure and remove domain. Multiple attempts made, consistently reproducible.

Home Assistant Core 2024.1.3 Home Assistant OS 11.4

Thanks. just like you said,problem was solved.but i think It is appropriate to put a prompt on the configuration screen of HomeKit Bridge.

Haaooo avatar Jan 18 '24 04:01 Haaooo

I don’t think that is the same issue.

Example to reproduce is a Device with two Entities from different Domains say Fan and Climate.

Problem: You select Include option and Fan and Climate from domains then select the Fan entity only. Both the Fan and Climate become exposed to HomeKit.

No Problem: You select Include option and Fan (but not Climate) from domains then select the Fan entity. Only the Fan becomes exposed to HomeKit.

Ah, understood. It seems there are two (possibly related) issues being discussed, and I chimed in to confirm the one regarding selecting a domain for inclusion but not entities within the domain, leading to all entities in said domain being included.

Due to the nature of the interface, in where granular control is implicit, I find this behaviour counterintuitive. However, I can also appreciate the logic of being able to include an entire domain without having to select all entities within.

Since I'm unsure of what the preferred behaviour/best UX would be, I won't be creating a separate issue for this. I think a notification such as suggested by @Haaooo would be helpful, though.

jsundgot avatar Jan 19 '24 10:01 jsundgot

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Repro steps were provided.

codyc1515 avatar Feb 02 '24 19:02 codyc1515

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Still happening.

codyc1515 avatar Feb 24 '24 23:02 codyc1515