ZHA cover tilt

[josef109]

Breaking change

Proposed change

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ x] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [ x] The code change is tested and works locally.
• [ x] Local tests pass. Your PR cannot be merged unless tests pass
• [ x] There is no commented out code in this PR.
• [ x] I have followed the development checklist
• [ x] I have followed the perfect PR recommendations
• [ x] The code has been formatted using Black (black --fast homeassistant tests)
• [ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @dmulcahey, @adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[Hedda]

Please fix the lint errors and add a PR description explaining the change.

@josef109 Bump this. Can you please fix the lint errors (spelling mistakes?) and add a description to your original post, similar to:

https://github.com/home-assistant/core/pull/86591

https://github.com/home-assistant/core/pull/85515

E.i. At least add a comment like ex.: "Add support for new "tilt" function to covers (e.g. windows covering) to the ZHA integration".

PS: You should also fix the check-box formatting under checklist in your original post (remove space so reads [x]and not [ x]).

PPS: @josef109 Off-topic but suggest you check out improved cover tests for zwave in https://github.com/home-assistant/core/pull/93458 if ZHA could maybe reuse those?

[shdb]

To give some feedback. I have this running quite well here.

Thanks for the work. It would be great to have this in core.

[tomasbedrich]

Hi @josef109, what is the status of this PR? I am maintaining my own a fork of ZHA only to mix upstream + your code. It would be extremely useful to have it merged. Thanks.

[Hedda]

Originally posted by @cremor in https://github.com/zigpy/zha-device-handlers/issues/1397#issuecomment-1723647093

I know that PR and I'd really like to see it merged. But sadly there has been no real change since May and the author doesn't respond to any messages (neither on GitHub nor in the HA forum).

@puddly Any chance you consider taking over this? Adding cover tilt support in devices like https://github.com/zigpy/zha-device-handlers/issues/1397 ?

For reference also see this feature request -> https://community.home-assistant.io/t/support-tilt-for-covers-in-zha/403146/

ZHA cover tilt support is needed for devices like example the blinds actuator by Insta GmbH -> https://github.com/zigpy/zha-device-handlers/issues/1397

[m67hoff]

I have been running and testing this for a few weeks now. It works extremely well, I have not seen any problem so far. I really wonder why ZHA does not support window blinds with tiltable slats (as other cover implementations do e.g. Z2M or Zwave). I think the tilt support is essential for using ZHA coverage. I know it's hard to understand if you don't have such "Venetian blinds", but they are very common in office buildings and modern energy efficient houses with large windows where you need to control solar heat with the tilt function of the cover (We spent €400 more per window to have tilting blinds as opposed to roller blinds. )

@emontnemery @josef109 What is still missing for this PR to be merged? It looks to me as if the lint errors have been fixed ....

@josef109 BTW: awesome work thank you very much. I see you regularly update this PR by merging HA:dev. Can you please go the last step and get the missing things done? (I own you a beer)

Is there anything I can help? (e.g. if this is really stuck, but I don't think so - take over an create an own PR ...)

[cremor]

e.g. if this is really stuck, but I don't think so - take over an create an own PR

Looks like this has already happened. @tomasbedrich created #102072

[puddly]

Closing now that #102072 has been merged.