core icon indicating copy to clipboard operation
core copied to clipboard

Add INVERT to switch_as_x

Open disforw opened this issue 1 year ago • 1 comments

Breaking change

Proposed change

Add the switch domain to the Switch_as_x integration to facilitate inverting a switch. This will allow the inversion of a switch from the helper UI.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

disforw avatar May 02 '23 03:05 disforw

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (switch_as_x) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switch_as_x can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switch_as_x Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar May 02 '23 03:05 home-assistant[bot]

Unit tests are missing.

Also it makes more sense to me to have this as a separate helper. Might also be very helpful to invert covers for example or other kind of devices. In fact I have this problem with a zwave cover, and I ended up rewiring it to inverse. This helper is switch_as_x and x is in all cases another platform i.e. light, fan etc. So inverse also not really fits this.

Maybe some core member can chime in and agree on this idea of a new helper.

bramstroker avatar May 09 '23 19:05 bramstroker